Accept bare cookies #2837
Merged
Accept bare cookies #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2837 +/- ##
=============================================
+ Coverage 88.387% 88.390% +0.003%
=============================================
Files 92 92
Lines 7156 7158 +2
Branches 1228 1229 +1
=============================================
+ Hits 6325 6327 +2
Misses 575 575
Partials 256 256 ☔ View full report in Codecov by Sentry. |
ahopkins
previously approved these changes
Nov 28, 2023
ahopkins
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers allow setting
document.cookie="foo"which causes them to sendcookie: foo, rather than the usual forcookie: bar=foo. WhatWG specs were altered around 2016 to note how Chrome had been doing this, with the meaning that cookie name is empty and only value is included.Discussion in:
httpwg/http-extensions#159
httpwg/http-extensions#1018
Fix #2835