Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bubble_env to benchmark. #1814

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Jan 27, 2023

See CHANGELOG.md.

@Gamenot
Copy link
Collaborator Author

Gamenot commented Feb 8, 2023

This will need to match the changes to the competition environment inspired by #1838 (comment) and particularly #1846.

@Gamenot Gamenot changed the base branch from develop to master February 10, 2023 18:43
@Gamenot Gamenot changed the base branch from master to develop February 10, 2023 18:53
@Gamenot Gamenot force-pushed the tucker/add-driving_smarts_full_v0 branch from 42334ff to 05c7d27 Compare February 10, 2023 18:59
@Gamenot Gamenot changed the base branch from develop to master February 10, 2023 19:00
@Gamenot Gamenot force-pushed the tucker/add-driving_smarts_full_v0 branch from 05c7d27 to 41eee14 Compare February 13, 2023 20:26
Comment on lines +38 to +45
traffic_mode (Literal["traffic_A"]): The version of bubble traffic to use.
action_space (ActionSpaceType): The action space the agent should use.
img_meters (float): The square side dimensions of the surface the top-down rgb image
portrays. This affects resolution.
img_pixels (float): The total number of pixels in the top-down rgb image. This affects
resolution.
headless (bool): If the environment should display sumo-gui.
seed (int): The seed of the environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring needs to be updated to match the checked_bubble_env_v0() input parameters.

from smarts.core.agent_interface import AgentInterface


def checked_bubble_env_v0(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps simply name it as bubble_env_v0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants