Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NeurIPS2022 competition agent to agent zoo #1838

Merged
merged 21 commits into from
Feb 10, 2023
Merged

Add NeurIPS2022 competition agent to agent zoo #1838

merged 21 commits into from
Feb 10, 2023

Conversation

Adaickalavan
Copy link
Member

@Adaickalavan Adaickalavan commented Feb 7, 2023

CHANGELOG.md Show resolved Hide resolved
@@ -0,0 +1,19 @@
[metadata]
name = smarts_agent_iamp_stub
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this name intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setup file simply installs smarts_agent_iamp package as dependency which contains the entire trained model. Thus I named this as <package_name>_stub. Any other naming system is welcomed. Alternatively, we may also consider sidestepping this setup file and somehow directly pip install smarts_agent_iamp package when users execute scl zoo install <agent_locator>.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine for now.

Copy link
Collaborator

@Gamenot Gamenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants