Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop needlessly writing to generated files. #556

Open
GriffinRichards opened this issue Nov 20, 2023 · 0 comments · May be fixed by #652
Open

Stop needlessly writing to generated files. #556

GriffinRichards opened this issue Nov 20, 2023 · 0 comments · May be fixed by #652
Assignees
Labels
release target This should be resolved before the next release

Comments

@GriffinRichards
Copy link
Collaborator

Currently Porymap will write (but not read) the generated files include/constants/map_groups.h and include/constants/layouts.h. This is because the project repos do not generate these files before they are needed. After the changes in pret/pokeemerald#1949 (and after they are synced to pokefirered and pokeruby), they are generated in time and Porymap doesn't need to write them anymore.

Given that this is a breaking change (if Porymap stops writing them users will need the changes in that PR) and that Porymap continuing to write the generated files is harmless, this should wait to be fixed alongside a breaking change of more consequence.

@GriffinRichards GriffinRichards added the release target This should be resolved before the next release label Aug 15, 2024
@GriffinRichards GriffinRichards self-assigned this Oct 1, 2024
@GriffinRichards GriffinRichards linked a pull request Dec 16, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release target This should be resolved before the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant