[Build System Rewrite] mapjson now takes output directory parameters.
#1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed generated files (layouts.h, map_groups.h) from git.
Icedude907
force-pushed
the
build-mapjson-improvement
branch
from
90ea86e to
7fa9819
Compare
1 task
7 tasks
Icedude907
force-pushed
the
build-mapjson-improvement
branch
from
6812f15 to
2b75819
Compare
GriffinRichards
approved these changes
Nov 24, 2023
6 tasks
issueWithLife
pushed a commit
to issueWithLife/pokeemerald
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all, I'm back.
This time, I'll try and spread my commits out into smaller chunks.
Previous PR was #1920
3 changes:
mapjsontakes parameters for output directories (C++11 compatible at GriffinRichards Request)Makefileno longer has redundant code shared withmake_tools.mkmapjsonare.gitignored correctly & made in the correct orderMore to come soon
Discord contact info
icedude907