-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign creation dialogs #652
Draft
GriffinRichards
wants to merge
37
commits into
huderlem:master
Choose a base branch
from
GriffinRichards:new-map-dialog
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… messages/handling
GriffinRichards
force-pushed
the
new-map-dialog
branch
from
December 16, 2024 20:40
86f65ed
to
d9be7d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAPSEC
, and map group)Among the internal changes, a few notable changes are:
Header
tab and theNew Map
dialog) and for new layouts (shared between theNew Map
andNew Layout
dialogs) have been combined into their own classes.AdvanceMapParser
file/namespace.TODO:
MAPSEC
s (i.e., without opening the region map editor)Closes #136
Closes #335
Closes #550
Closes #556
Closes #596
Closes #614
Closes #651
Addresses the first point in #638