Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fine classes in trec dataset #4801

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Fix fine classes in trec dataset #4801

merged 5 commits into from
Aug 22, 2022

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Aug 8, 2022 •
edited
Loading

This PR:

  • replaces the fine labels, so that there are 50 instead of 47
  • once more labels are added, all they (fine and coarse) have been re-ordered, so that they align with the order in: https://cogcomp.seas.upenn.edu/Data/QA/QC/definition.html
  • the feature names have been fixed: fine_label instead of label-fine
    • to sneak-case (underscores instead of hyphens)
    • words have been reordered

Fix #4790.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 8, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova albertvillanova changed the title Fix 4790 Fix fine classes in trec dataset Aug 9, 2022
lhoestq
lhoestq approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks for fixing the labels !

@albertvillanova albertvillanova merged commit cd00f13 into huggingface:main Aug 22, 2022
@albertvillanova albertvillanova deleted the fix-4790 branch August 22, 2022 16:14
@albertvillanova albertvillanova mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with fine classes in trec dataset
3 participants
@albertvillanova @HuggingFaceDocBuilderDev @lhoestq