Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly builds #216

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix nightly builds #216

merged 1 commit into from
May 28, 2024

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented May 28, 2024

What this does

Test artifacts were not git lfs pulled when building docker images and instead only the reference files were present — which obviously fails when trying to read them. This adds git lfs when checking out code to fix it.

How it was tested

Manually built & tested images on this branch successfully


This change is Reviewable

@aliberts aliberts changed the title Add git lfs Fix nightly builds May 28, 2024
@aliberts aliberts added ✅ Tests Adds or modifies testing ⚙️ Infra/CI Infra / CI-related and removed ✅ Tests Adds or modifies testing labels May 28, 2024
@aliberts aliberts marked this pull request as ready for review May 28, 2024 08:23
@aliberts aliberts self-assigned this May 28, 2024
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS

@Cadene Cadene merged commit 7ec76ee into main May 28, 2024
10 checks passed
@Cadene Cadene deleted the user/aliberts/2024_05_28_fix_nightly branch May 28, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Infra/CI Infra / CI-related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants