Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cuda for end-to-end tests #222

Merged
merged 1 commit into from
May 29, 2024

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented May 29, 2024

What this does

Enables device=cuda for end-to-end tests on gpu

How it was tested

Did a build & nightly run on this branch, with end-to-end tests successfully using device=cuda (while cpu remains unchanged)

How to checkout & try? (for the reviewer)

N/A


This change is Reviewable

@aliberts aliberts added ✅ Tests Adds or modifies testing ⚙️ Infra/CI Infra / CI-related labels May 29, 2024
@aliberts aliberts self-assigned this May 29, 2024
@aliberts aliberts changed the title Enable gpu for end-to-end tests Enable cuda for end-to-end tests May 29, 2024
@aliberts aliberts marked this pull request as ready for review May 29, 2024 20:58
@aliberts aliberts enabled auto-merge (squash) May 29, 2024 21:00
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aliberts aliberts merged commit 1331068 into main May 29, 2024
12 checks passed
@aliberts aliberts deleted the user/aliberts/2024_05_29_enable_gpu_end_to_end_tests branch May 29, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Infra/CI Infra / CI-related ✅ Tests Adds or modifies testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants