-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves Type Annotations #252
Improves Type Annotations #252
Conversation
Hi @alexander-soare, for some reason I'm not able to tag anyone to review my PR, let me know what I should do |
Thanks for the PR! I tagged myself and will take a look early this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for revising! Still blocking based on @aliberts' ask.
What this does
I want to contribute more often so I thought maybe a PR that goes through "obvious" missing annotations could be a good first PR.
How it was tested
poetry run pytest tests/
This change is