Improves Type Annotations #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexander-soare, for some reason I'm not able to tag anyone to review my PR, let me know what I should do |
|
Thanks for the PR! I tagged myself and will take a look early this week. |
alexander-soare
requested changes
Jun 10, 2024
alexander-soare
requested changes
Jun 10, 2024
There was a problem hiding this comment.
Thanks for revising! Still blocking based on @aliberts' ask.
WaelKarkoub
requested review from
Cadene,
qgallouedec,
alexander-soare and
aliberts
alexander-soare
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
I want to contribute more often so I thought maybe a PR that goes through "obvious" missing annotations could be a good first PR.
How it was tested
poetry run pytest tests/This change is