Fix make_dataset to match transforms config #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliberts
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Can you enable image_transforms in the test-act-pusht-tutorial target as well?
Co-authored-by: Simon Alibert <75076266+aliberts@users.noreply.github.com>
aliberts
approved these changes
Jun 12, 2024
aliberts
deleted the
user/marinabar/2024_06_12_fix_make_dataset_transforms
branch
aliberts
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
factory.pywhen callingget_image_transformsand the configuration structure.training.image_transforms.enable=truein end-to-end tests as this issue passed CI unnoticed.How it was tested
Newly modified CI end-to-end train test failed before modification. Test does pass after the fix.
How to checkout & try? (for the reviewer)
You can run the test yourself, or run
python lerobot/scripts/train.py device=cuda \ env=aloha \ env.task=AlohaTransferCube-v0 \ dataset_repo_id=lerobot/aloha_sim_transfer_cube_human \ policy=act \ training.offline_steps=1000 \ training.image_transforms.enable=trueThis change is