-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make_dataset to match transforms config #264
Fix make_dataset to match transforms config #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Just one blocking comment from me, feel free to include the rest or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you enable image_transforms in the test-act-pusht-tutorial
target as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 5026796
Co-authored-by: Simon Alibert <75076266+aliberts@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marinabar! 🤗
What this does
factory.py
when callingget_image_transforms
and the configuration structure.training.image_transforms.enable=true
in end-to-end tests as this issue passed CI unnoticed.How it was tested
Newly modified CI end-to-end train test failed before modification. Test does pass after the fix.
How to checkout & try? (for the reviewer)
You can run the test yourself, or run
This change is