Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to detail the lerobot dataset format #275

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

thomwolf
Copy link
Member

@thomwolf thomwolf commented Jun 17, 2024

What this does

This Pull Request detail how the LeRobot Dataset format is structured and created.
It also adds a mention of the often overlooked DATA_DIR environment variable.

It's extracted from #246

How it was tested

It's only a readme update thus no tests.

How to checkout & try? (for the reviewer)

Read the changes.


This change is Reviewable

@thomwolf thomwolf marked this pull request as ready for review June 17, 2024 08:57
Copy link
Collaborator

@alexander-soare alexander-soare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @thomwolf . I have comments but my disposition is approved / non-blocking.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Here are the important details and internal structure organization of a typical `LeRobotDataset` instantiated with `dataset = LeRobotDataset("lerobot/aloha_static_coffee")`. The exact features will change from dataset to dataset but not the main aspects:

```
dataset attributes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way of flagging this snippet so that there's a CI mechanism to draw our attention to it in case we change anything in the datasets module ... or something, anything to make sure it doesn't go stale. I wonder if someone at HF has solved this problem...

Copy link
Member Author

@thomwolf thomwolf Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, we have that in transformers for docstring examples. It's quite a lot of work to setup and maintain so I would advise to wait that the library has really built a large community of users before diving in this.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@aliberts aliberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
One change for me, feel free to take the nits or not.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aliberts aliberts added the 📝 Documentation Improvements or additions to documentation label Jun 17, 2024
@thomwolf
Copy link
Member Author

Thanks @alexander-soare and @aliberts Added all the suggestions.

Feel free to merge when you feel like.

Copy link
Collaborator

@aliberts aliberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thomwolf! 🙏
All good to me, I'll let @alexander-soare merge if it's good for him too

@alexander-soare alexander-soare merged commit 56199fb into main Jun 18, 2024
3 checks passed
@alexander-soare alexander-soare deleted the thomwolf_2024_06_17_readme_update branch June 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants