Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
OpenCVCamera
for thread safe operationAdds(actually doesn't work)yield
in pytest monkeypatching fixture for camerasMockVideoCapture
fromcv2.VideoCapture
, which was causing ugly errors when trying to monkeypatchcv2.VideoCapture
with it.MockVideoCapture
for more accurate behaviornp.testing.assert_allclose
instead ofassert np.allclose
for displaying errors nicelyTODO (this PR or another one):
How it was tested
Running
pytest -v -k "opencv" tests/test_cameras.py
doesn't raise any segmentation fault anymore, but does still raise assert errors onnp.allclose
(separate issue)EDIT: For
mock=True
this is now fixed. It was caused by the monkeypatch not actually being applied and therefore was using the real camera instead of the mock one.How to checkout & try? (for the reviewer)
pytest -v -k "opencv" tests/test_cameras.py