-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisualBertOnnx #663
VisualBertOnnx #663
Conversation
…) correctness and doing export for every vbert task
…) correctness and doing export for every vbert task
Looks good to me so far! Maybe you'll just run into the issue that For 2., I guess it's because of a head in VisualBertForQuestionAnswering that is not used in the base model: https://github.com/huggingface/transformers/blob/588faad1062198e45cf3aebed21dc1fc1e1ed0d7/src/transformers/models/visual_bert/modeling_visual_bert.py#L1184 . If it is just for testing purposes, the warnings are expected. Otherwise you can try |
* improve doc * Update docs/source/exporters/onnx/usage_guides/export_a_model.mdx Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com> * fix reference to ortmodel * Update docs/source/exporters/onnx/usage_guides/export_a_model.mdx * Update docs/source/exporters/onnx/usage_guides/export_a_model.mdx * Update docs/source/exporters/onnx/usage_guides/export_a_model.mdx * Update docs/source/exporters/onnx/usage_guides/export_a_model.mdx * Update docs/source/exporters/onnx/usage_guides/export_a_model.mdx Co-authored-by: Michael Benayoun <mickbenayoun@gmail.com>
* get_exporter_config_constructor and export parameter order updated + added 1 missing import * Update docs/source/exporters/onnx/usage_guides/contribute.mdx Co-authored-by: fxmarty <9808326+fxmarty@users.noreply.github.com> Co-authored-by: fxmarty <9808326+fxmarty@users.noreply.github.com>
…) correctness and doing export for every vbert task
…) correctness and doing export for every vbert task
The documentation is not available anymore as the PR was closed or merged. |
Hi @mszsorondo , not sure why these two show in the commit history but it should probably not: Github commit history / diff is sometimes bugged on PRs, but maybe something is messed up? |
@fxmarty |
@mszsorondo All good! for the check_code_quality test, you will just need to run |
What does this PR do?
Start implementing VisualBERT for Onnx exporting
Pending:
Implement outputs
Executing one export for each VisualBERT implementation
VisualBertDummyInputGenerator
Questions
@fxmarty @younesbelkada I would appreciate any help with this
Is inputs() is correctly implemented?
raises the following warning:
So this is not expected, any hint on how to solve this?
Fixes #555 (issue)