Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try GitHub Actions CI #68

Closed
wants to merge 3 commits into from
Closed

Try GitHub Actions CI #68

wants to merge 3 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 22, 2019

@cclauss
Copy link
Contributor Author

cclauss commented Aug 22, 2019

There is this really weird thing where actions do not work on forks but only on the source repo. I think if you either land these PRs or you recreate them as repo owner then they work but not on forks because that "pull" message is not received.

It would be great if you could help me grok that.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 22, 2019

Nope. Inexplicable.

@hugovk hugovk mentioned this pull request Aug 22, 2019
@cclauss
Copy link
Contributor Author

cclauss commented Aug 22, 2019

Now they ran (see above)

@cclauss
Copy link
Contributor Author

cclauss commented Aug 22, 2019

Closing in favor of #70

@cclauss cclauss closed this Aug 22, 2019
@hugovk
Copy link
Owner

hugovk commented Aug 22, 2019

Yep, your theory seems correct. Just needs some tweaks to install requirements to make it pass. I'll check it later, and probably make it use tox like AP. Thanks!

@cclauss cclauss deleted the patch-2 branch August 22, 2019 08:24
@cclauss
Copy link
Contributor Author

cclauss commented Aug 22, 2019

If you ever have spare cycles to help on a port to Python 3, checkout nodejs/node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants