-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try GitHub Actions CI #70
Conversation
DeepCode Report (#0078ac)DeepCode analyzed this pull request. |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 2 2
Lines 290 290
=======================================
Hits 287 287
Misses 3 3
Continue to review full report at Codecov.
|
6f59d27
to
5f8a35a
Compare
Thanks again for the PRs, this is looking good. I've replicated what Azure Pipelines is doing, with the exception of uploading coverage to Codecov, and the sdist check. They can wait for later. GitHub Actions looks very good. This is only using it as CI, and it's very like AP. Improvements:
https://help.github.com/en/articles/events-that-trigger-workflows#webhook-events says of
And
What a lot of events!
Does that mean
Is that saying to use both It also means for each event, there's 2 builds. 2 × (3 OS × 2 Python tests + 1 OS × 1 Python lint) = 2 × 7 = 14. Still within the 20 limit here, but AP doesn't double up. Open questions
|
@chrispat Any comments or recommendations on this exploration? |
Same as #68 but made from a non-fork branch.
cc @cclauss.