Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MarkdownPost::getLatestPosts helper to sort using the DateTime object timestamp #1235

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

caendesilva
Copy link
Member

Since the front matter data can differ in format, we should sort using the normalized DateTime object. By using the Unix timestamp we will always be able to sort using the proper order in time.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1235 (13f8f45) into master (66f7c08) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master     #1235     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1315      2630   +1315     
=============================================
  Files            152       304    +152     
  Lines           3453      6910   +3457     
=============================================
+ Hits            3453      6910   +3457     
Impacted Files Coverage Δ
packages/framework/src/Pages/MarkdownPost.php 100.00% <100.00%> (ø)
...ork/src/Framework/Concerns/TracksExecutionTime.php 100.00% <0.00%> (ø)
...packages/framework/src/Support/Models/RouteKey.php 100.00% <0.00%> (ø)
...c/Foundation/Concerns/BaseFoundationCollection.php 100.00% <0.00%> (ø)
...undation/Concerns/HandlesFoundationCollections.php 100.00% <0.00%> (ø)
...ramework/src/Console/Commands/BuildSiteCommand.php 100.00% <0.00%> (ø)
...amework/Features/Metadata/Elements/LinkElement.php 100.00% <0.00%> (ø)
...src/Framework/Exceptions/FileNotFoundException.php 100.00% <0.00%> (ø)
...elop/packages/framework/src/Facades/Filesystem.php 100.00% <0.00%> (ø)
...ramework/Views/Components/BreadcrumbsComponent.php 100.00% <0.00%> (ø)
... and 143 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 8, 2023 10:55
@caendesilva caendesilva merged commit 637b873 into master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant