Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydePHP v1.0.0 - Release Candidate Two #1244

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

caendesilva
Copy link
Member

v1.0.0-RC.2 - 2023-03-10

Added

  • Added a new HydeKernel::currentPage() method to return the page being rendered.

Changed

  • Renamed global $currentRoute and $currentPage variables to $route and $routeKey respectively.
  • Renamed Render::getCurrentRoute() to Render::getRoute() to match renamed property.
  • Renamed Render::getCurrentPage() to Render::getRouteKey() to match renamed property.

Deprecated

This release candidate version contains a few deprecations, these will be removed before the final 1.0.0 release.

  • Deprecate RouteKey::normalize method as it no longer performs any normalization.
  • Deprecate RenderData::getCurrentRoute() as it is renamed to getRoute() to match renamed property.
    • This change affects the Render::getCurrentRoute() and Hyde::currentRoute() facade methods.
  • Deprecate RenderData::getCurrentPage() as it is renamed to getRouteKey() to match renamed property.
    • This change affects the Render::getCurrentPage() and Hyde::currentPage() facade methods.

Removed

Fixed

@caendesilva caendesilva marked this pull request as ready for review March 10, 2023 14:03
@caendesilva caendesilva force-pushed the release-candidate-two branch from 3dc1b46 to 42488ca Compare March 10, 2023 14:04
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1244 (42488ca) into master (c95e72c) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              master     #1244     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1318      2636   +1318     
=============================================
  Files            152       304    +152     
  Lines           3461      6922   +3461     
=============================================
+ Hits            3461      6922   +3461     
Impacted Files Coverage Δ
packages/framework/src/Foundation/HydeKernel.php 100.00% <ø> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 303925d into master Mar 10, 2023
@caendesilva caendesilva deleted the release-candidate-two branch March 10, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for dot notation in route key normalization
1 participant