-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Recreate the HydeSearch plugin with Alpine.js #2029
Merged
caendesilva
merged 30 commits into
refactor-hydefront-styles-to-tailwind
from
recreate-the-hydesearch-plugin-with-alpine
Nov 16, 2024
Merged
[2.x] Recreate the HydeSearch plugin with Alpine.js #2029
caendesilva
merged 30 commits into
refactor-hydefront-styles-to-tailwind
from
recreate-the-hydesearch-plugin-with-alpine
Nov 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
changed the title
[2.x] Recreate the HydeSearct plugin with Alpine.js
[2.x] Recreate the HydeSearch plugin with Alpine.js
Nov 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-hydefront-styles-to-tailwind #2029 +/- ##
=========================================================================
Coverage 100.00% 100.00%
Complexity 1906 1906
=========================================================================
Files 195 195
Lines 5078 5078
=========================================================================
Hits 5078 5078 ☔ View full report in Codecov by Sentry. |
This reverts commit fe4cdb9.
I think it makes sense to hide the keyboard shortcut help text when there are search results, for a few reasons:
|
caendesilva
merged commit Nov 16, 2024
1f4e3d4
into
refactor-hydefront-styles-to-tailwind
12 checks passed
This was referenced Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the HydeSearch plugin with an Alpine.js and Blade implementation to make it more customizable and to reduce external dependencies. It also lets us more easily couple fixes and improvements to Hyde versions.