[2.x] Extract vendor file for the HydeSearch script #2031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Extracts a file in the framework vendor resources for the bulk HydeSearch scripts introduced by #2029 as it feels wrong to have so much JavaScript inline, especially as we don't really want users to tinker with it unless they know what they're doing.
Note that I decided against documenting the overloading feature as I think it's such a slim use case, and anyone determined to do it will easily be able to find it in the source.
Motivation
Benefits of this approach:
Potential concerns:
However, given Hyde's focus on simplicity and working out of the box, I think the benefits outweigh the drawbacks. We could even add a simple minified version of the file to use in production.
Customization
The search functionality can be customized by creating a
resources/js/HydeSearch.js
file in your project. If this file exists, Hyde will use your implementation instead of the default one.It follows the same pattern Hyde uses for other assets and provides a clear override mechanism. Here's why it's intuitive: