Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor validation service #608

Merged
merged 18 commits into from
Oct 27, 2022
Merged

Refactor validation service #608

merged 18 commits into from
Oct 27, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva
Move class ValidationResult to new Validation namespace
ca55170
@caendesilva
Convert concatenation to string interpolation
dc0271b
@caendesilva
Introduce constants for status codes
88a0ad2
@caendesilva
Make constants protected
b9b01ee
@caendesilva
Make constants public
25bb1de
@caendesilva
Extract helper for shared code
2d4e405
@caendesilva
Return static instead of void
d9153b2
@caendesilva
Shorten return operation
9f829b6
@caendesilva
Add spacing before return value
00c6934
@caendesilva
Move class ValidationService to Features\Validation namespace
9ce89ab
@caendesilva
Rename ValidationService to SiteValidator
50d075f
@caendesilva
Rename test for renamed class
1dbb543
@caendesilva
Add noinspection tag as methods are entry points
45798d3
@caendesilva
Revert "Add noinspection tag as methods are entry points"
45b8e55 
This reverts commit 45798d3.
@caendesilva
Revert "Rename test for renamed class"
44ab025 
This reverts commit 1dbb543.
@caendesilva
Revert "Rename ValidationService to SiteValidator"
2858a8b 
This reverts commit 50d075f.
@caendesilva
Revert "Move class ValidationService to Features\Validation namespace"
6b9afe6 
This reverts commit 9ce89ab.
@caendesilva
Revert "Move class ValidationResult to new Validation namespace"
1f5ba86 
This reverts commit ca55170.
@caendesilva caendesilva marked this pull request as ready for review October 27, 2022 20:08
@caendesilva caendesilva merged commit d9af621 into experimental Oct 27, 2022
@caendesilva caendesilva deleted the refactor-validation-service branch October 27, 2022 20:09
@caendesilva caendesilva mentioned this pull request Oct 29, 2022
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caendesilva