-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HydePHP v1.0 Goals - Massive Internal Restructure #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty-to-always-begin-with-_media- Normalize internal image path storage
…ageObject Aggressively simplify and inline action FindsContentLengthForRemoteImageObject
Refactor FeaturedImage component to handle all semantic HTML assembly logic in the view
…Schemas-trait Remove ConstructsPageSchemas schemas trait
caendesilva
changed the title
HydePHP v1.0 - Massive Internal Restructure
HydePHP v1.0 Goals - Massive Internal Restructure
Oct 30, 2022
Refactor the page data factory pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
This absolutely massive pull request makes incredibly breaking changes to the internal API, so much so it could almost be considered a rewrite. Literally all framework files have been changed, and probably about 90% all of them have had their namespaces changed. I am sorry.
I do feel like this is the time to do stuff like this, since next release is v1.0, and it's now or never. Hopefully these breaking changes will lead to better stability and maintainability in the future.
Changes
About the development
I quickly learned that these rapidly changing experimental changes needed to be organized, so I soon did so in pull requests to this experimental branch, as this allowed me to iterate very quickly.
Associated pull requests
Steps needed before merge
Footnotes
https://github.com/hydephp/develop/discussions/625 ↩