Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydePHP v1.0 Goals - Massive Internal Restructure #623

Merged
merged 825 commits into from
Oct 31, 2022
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Oct 29, 2022

Preface

This absolutely massive pull request makes incredibly breaking changes to the internal API, so much so it could almost be considered a rewrite. Literally all framework files have been changed, and probably about 90% all of them have had their namespaces changed. I am sorry.

I do feel like this is the time to do stuff like this, since next release is v1.0, and it's now or never. Hopefully these breaking changes will lead to better stability and maintainability in the future.

Changes

About the development

I quickly learned that these rapidly changing experimental changes needed to be organized, so I soon did so in pull requests to this experimental branch, as this allowed me to iterate very quickly.

Associated pull requests

Steps needed before merge

  • Get feedback about the new directory structure and namespaces of the framework package1
  • Fully rewrite the new factory model for page data constructors
  • Code reviews? (feel free to review some of the files if you have a second!)
  • Fix missing coverage

Footnotes

  1. https://github.com/hydephp/develop/discussions/625

caendesilva and others added 30 commits October 28, 2022 22:46
…ty-to-always-begin-with-_media-

Normalize internal image path storage
…ageObject

Aggressively simplify and inline action FindsContentLengthForRemoteImageObject
Refactor FeaturedImage component to handle all semantic HTML assembly logic in the view
@caendesilva caendesilva changed the title HydePHP v1.0 - Massive Internal Restructure HydePHP v1.0 Goals - Massive Internal Restructure Oct 30, 2022
@caendesilva caendesilva marked this pull request as ready for review October 31, 2022 10:16
@caendesilva caendesilva merged commit 65b5c13 into master Oct 31, 2022
@caendesilva caendesilva deleted the upcoming branch October 31, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants