Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hydro_deploy): process perf out_file in-memory using separate .exec call #1365

Closed
MingweiSamuel opened this issue Jul 29, 2024 · 0 comments · Fixed by #1372
Closed

refactor(hydro_deploy): process perf out_file in-memory using separate .exec call #1365

MingweiSamuel opened this issue Jul 29, 2024 · 0 comments · Fixed by #1372

Comments

@MingweiSamuel
Copy link
Member

MingweiSamuel commented Jul 29, 2024 •
edited
Loading

hmm is this inherently assuming bash-like shell that uses ; and >? We could clean this up by doing just perf record. And then instead of the logic where we copy down the out_file we could instead exec perf_script and then stream the stdout down through the AsyncProcess APIs. Which is kinda nice because then it keeps the result of perf script in memory for processing by the flamegraph library.

Originally posted by @shadaj in #1313 (comment)
This was referenced Jul 29, 2024
Merged
Merged
MingweiSamuel added a commit that referenced this issue Aug 2, 2024
@MingweiSamuel
refactor(hydro_deploy)!: Deployment.stop() for graceful shutdown in…
a214786 
…cluding updated `perf` profile downloading (#1370)

* `perf` profile downloading moved from the `drop()` impl to `async fn
stop()`
* download perf data via stdout
* update async-ssh2-lite to 0.5 to cleanup tokio compat issues

WIP for #1365

BREAKING CHANGE: to get `perf` data, calling `.stop().await` is now
required.
@MingweiSamuel MingweiSamuel mentioned this issue Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(hydro_deploy)!: end-to-end flamegraph generation, fix #1365 MingweiSamuel/hydroflow
1 participant
@MingweiSamuel