-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hydro_deploy)!: end-to-end flamegraph generation, fix #1365 #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: also do this for localhost |
MingweiSamuel
force-pushed
the
hd-inferno
branch
from
August 2, 2024 18:26
47c8161
to
1146268
Compare
MingweiSamuel
commented
Aug 2, 2024
shadaj
reviewed
Aug 2, 2024
MingweiSamuel
commented
Aug 3, 2024
MingweiSamuel
force-pushed
the
hd-inferno
branch
from
August 5, 2024 17:00
0621f27
to
010bb79
Compare
MingweiSamuel
changed the title
refactor(hydro_deploy)!: end-to-end flamegraph generation
refactor(hydro_deploy)!: end-to-end flamegraph generation, fix #1365
Aug 5, 2024
MingweiSamuel
force-pushed
the
hd-inferno
branch
from
August 5, 2024 19:42
f50f68b
to
81a2a2c
Compare
shadaj
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1370
Fixes #1365
BREAKING CHANGE: changes PerfConfig creation and probably other stuff