Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hydro_deploy)!: end-to-end flamegraph generation, fix #1365 #1372

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Aug 1, 2024

Depends on #1370

Fixes #1365

BREAKING CHANGE: changes PerfConfig creation and probably other stuff

@MingweiSamuel
Copy link
Member Author

TODO: also do this for localhost

@MingweiSamuel MingweiSamuel marked this pull request as ready for review August 2, 2024 18:25
hydro_deploy/core/src/ssh.rs Outdated Show resolved Hide resolved
@MingweiSamuel MingweiSamuel changed the title refactor(hydro_deploy)!: end-to-end flamegraph generation refactor(hydro_deploy)!: end-to-end flamegraph generation, fix #1365 Aug 5, 2024
Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

hydro_deploy/core/src/localhost/mod.rs Show resolved Hide resolved
@MingweiSamuel MingweiSamuel merged commit bb081d3 into hydro-project:main Aug 6, 2024
13 checks passed
@MingweiSamuel MingweiSamuel deleted the hd-inferno branch August 6, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(hydro_deploy): process perf out_file in-memory using separate .exec call
2 participants