Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services on multiple Localhost instances should be able to talk to eachother #841

Closed
shadaj opened this issue Jul 13, 2023 · 0 comments · Fixed by #1403
Closed

Services on multiple Localhost instances should be able to talk to eachother #841

shadaj opened this issue Jul 13, 2023 · 0 comments · Fixed by #1403
Assignees
@shadaj
Labels
bug Something isn't working deploy Hydro Deploy, or other deployment enhancement New feature or request
Milestone
0.9 Release

Comments

@shadaj
Copy link
Member

shadaj commented Jul 13, 2023

Right now, we fail to find a connection strategy because we the instances have different IDs. We should probably just get rid of those IDs, since multiple localhost instances will always refer to the same machine.
@shadaj shadaj added the deploy Hydro Deploy, or other deployment label Jul 13, 2023
@shadaj shadaj self-assigned this Jul 13, 2023
@shadaj shadaj added the bug Something isn't working label Jul 13, 2023
@jhellerstein jhellerstein added deploy Hydro Deploy, or other deployment and removed deploy Hydro Deploy, or other deployment labels Jul 21, 2023
@jhellerstein jhellerstein added this to the 0.5 Release milestone Aug 14, 2023
@jhellerstein jhellerstein modified the milestones: 0.5 Release, 0.6 Release Sep 28, 2023
@jhellerstein jhellerstein modified the milestones: 0.6 Release, 0.7 Release Feb 1, 2024
@MingweiSamuel MingweiSamuel added the enhancement New feature or request label Mar 26, 2024
@jhellerstein jhellerstein modified the milestones: 0.7 Release, 0.8 Mar 28, 2024
shadaj added a commit that referenced this issue Aug 20, 2024
@shadaj
fix(hydro_deploy): only instantiate Localhost once
20c2603 
Fixes #841
@shadaj shadaj mentioned this issue Aug 20, 2024
Merged
shadaj added a commit that referenced this issue Aug 20, 2024
@shadaj
fix(hydro_deploy): only instantiate Localhost once
9c1e659 
Fixes #841
shadaj added a commit that referenced this issue Aug 20, 2024
@shadaj
fix(hydro_deploy): only instantiate Localhost once
db297a5 
Fixes #841
shadaj added a commit that referenced this issue Aug 22, 2024
@shadaj
fix(hydro_deploy): only instantiate Localhost once
22e5a1d 
Fixes #841
@shadaj shadaj closed this as completed in 63b528f Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shadaj shadaj

Labels
bug Something isn't working deploy Hydro Deploy, or other deployment enhancement New feature or request
Projects
None yet
Milestone
0.9 Release
Development

Successfully merging a pull request may close this issue.

fix(hydro_deploy): only instantiate Localhost once hydro-project/hydroflow
3 participants
@jhellerstein @shadaj @MingweiSamuel