Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hydro_deploy): only instantiate Localhost once #1403

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix(hydro_deploy): only instantiate Localhost once #1403

merged 1 commit into from
Aug 22, 2024

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Aug 20, 2024 •
edited
Loading

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 20, 2024 •
edited
Loading

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22e5a1d
Status: ✅  Deploy successful!
Preview URL: https://3174a986.hydroflow.pages.dev
Branch Preview URL: https://pr1403.hydroflow.pages.dev

View logs

@shadaj shadaj force-pushed the pr1403 branch 2 times, most recently from 9c1e659 to db297a5 Compare August 20, 2024 21:47
MingweiSamuel
MingweiSamuel approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is client_only still needed on localhost? Perhaps LocalhostHost should be stateless and have ID 0 (or something) reserved for it

@shadaj shadaj mentioned this pull request Aug 22, 2024
Merged
@shadaj shadaj merged commit 63b528f into main Aug 22, 2024
29 checks passed
@shadaj shadaj deleted the pr1403 branch August 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MingweiSamuel MingweiSamuel MingweiSamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Services on multiple Localhost instances should be able to talk to eachother
2 participants
@shadaj @MingweiSamuel