feat(client): deprecate client::conn::{Builder, handshake} #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
3063-deprecated
branch
from
6f8be87
to
3740cc8
Compare
`client::conn::{SendRequest, Connection, Builder, handshake}` are deprecated
as they are removed in 1.0.
tower_client is updated so it does not use the deprecated API.
seanmonstar
force-pushed
the
3063-deprecated
branch
from
3740cc8
to
5e46a74
Compare
This was referenced Mar 7, 2023
oddgrd
pushed a commit
to oddgrd/hyper
that referenced
this pull request
Mar 7, 2023
`client::conn::{SendRequest, Connection, Builder, handshake}` are deprecated as they are removed in 1.0.
This adds the `deprecated` feature to Cargo, and only when `hyper/deprecated` is enabled will these warnings be emitted.
Co-authored-by: KOVACS Tamas <ktamas@fastmail.fm>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #3063, this includes just the deprecated stuff. It builds off #3155, so that must merge first.