Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SNYK warnings #277

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Address SNYK warnings #277

merged 2 commits into from
Nov 23, 2023

Conversation

ryjones
Copy link
Member

@ryjones ryjones commented Nov 22, 2023

No description provided.

Signed-off-by: Ry Jones <ry@linux.com>
@swcurran
Copy link
Member

@berendsliedrecht — what do you think of the test failures? Are they relevant to the change, or gremlins.

Thanks, @ryjones — I should have done that, and will next time. I just thought there might be some sort of setting that enabled dependabot-type, DCO-loving PRs to be produced from Snyk :-).

@berendsliedrecht
Copy link
Contributor

@swcurran let me have a look. I think we generate some number non-deterministically which made the test fail this one time (assumption based on the error below).

thread 'main' panicked at 'Unable to create or update the revocation state: Error { kind: InvalidState, cause: None, message: Some("Revocation index is outside of valid range") }', src\services\prover.rs:64:49

Will hopefully provide a fix asap.

Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
@swcurran swcurran merged commit d00d8d1 into main Nov 23, 2023
23 of 26 checks passed
@ryjones ryjones deleted the SNYK branch November 24, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants