Add more tracing logs to transaction pool #4413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java
Fixed
Show fixed
Hide fixed
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java
Fixed
Show fixed
Hide fixed
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java
Fixed
Show fixed
Hide fixed
.../org/hyperledger/besu/ethereum/eth/transactions/sorter/BaseFeePendingTransactionsSorter.java
Fixed
Show fixed
Hide fixed
.../org/hyperledger/besu/ethereum/eth/transactions/sorter/BaseFeePendingTransactionsSorter.java
Fixed
Show fixed
Hide fixed
.../org/hyperledger/besu/ethereum/eth/transactions/sorter/BaseFeePendingTransactionsSorter.java
Fixed
Show fixed
Hide fixed
...org/hyperledger/besu/ethereum/eth/transactions/sorter/AbstractPendingTransactionsSorter.java
Fixed
Show fixed
Hide fixed
|
This pull request introduces 4 alerts when merging 98d19df into 5e15625 - view on LGTM.com new alerts:
|
fab-10
force-pushed
the
tx-pool-tracing
branch
4 times, most recently
from
4b5f43b
to
c438ebc
Compare
| LOG, | ||
| "Adding {} to pending transactions, range type {}", | ||
| transactionInfo::toTraceLog, | ||
| kind::toString); |
Check notice
Code scanning / CodeQL
Useless toString on String
fab-10
force-pushed
the
tx-pool-tracing
branch
3 times, most recently
from
87aa77d
to
11e4a6d
Compare
.../src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionsForSenderInfo.java
Fixed
Show fixed
Hide fixed
| LOG, | ||
| "Evicted {} due to too many transactions from sender {}", | ||
| tx::toTraceLog, | ||
| senderTxInfos::toString)); |
Check notice
Code scanning / CodeQL
Use of default toString()
...org/hyperledger/besu/ethereum/eth/transactions/sorter/AbstractPendingTransactionsSorter.java
Fixed
Show fixed
Hide fixed
...org/hyperledger/besu/ethereum/eth/transactions/sorter/AbstractPendingTransactionsSorter.java
Fixed
Show fixed
Hide fixed
fab-10
force-pushed
the
tx-pool-tracing
branch
5 times, most recently
from
dc9ac05
to
db4015c
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
tx-pool-tracing
branch
from
db4015c
to
5a506f6
Compare
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Merged
2 tasks
# Conflicts: # CHANGELOG.md # ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockTransactionSelector.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPool.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionsForSenderInfo.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/sorter/AbstractPendingTransactionsSorter.java # ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/sorter/BaseFeePendingTransactionsSorter.java # ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionPoolTest.java
|
Closing this since it has been merged as part of #4425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fabio Di Fabio fabio.difabio@consensys.net
PR description
This PR only adds trace logs that are useful for debbuging the empty blocks issues, indeed using these new trace logs it was possible to improve the transaction pool in #4425
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog