Transaction pool improvements to avoid filling the pool with not executable transactions #4425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| LOG, | ||
| "Adding {} to pending transactions, range type {}", | ||
| transactionInfo::toTraceLog, | ||
| kind::toString); |
Check notice
Code scanning / CodeQL
Useless toString on String
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
changed the title
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
2 tasks
fab-10
changed the title
jflo
approved these changes
Sep 22, 2022
| traceLambda(LOG, "Added remote transaction {}", transaction::toTraceLog); | ||
| addedTransactions.add(transaction); | ||
| break; | ||
| case ALREADY_KNOWN: |
There was a problem hiding this comment.
Does this mean the duplicate check at 145 is redundant with one the validateRemoteTransaction() method does? Optimization potential if we can avoid a full scan running twice.
| } | ||
| } | ||
|
|
||
| public List<Transaction> signalInvalidTransaction(final Transaction transaction) { |
There was a problem hiding this comment.
The return value here is not intuitive based on the method name. We should probably either add javadoc describing it, or rename to something like transactionsRemovedAfter(Transaction invalidTransaction)
| .filter(tx::equals) | ||
| .isPresent()) | ||
| .findFirst(); | ||
| private static class LowestInvalidNonceCache { |
There was a problem hiding this comment.
This is pretty big for an inner class, maybe pull it out into its own class?
|
merged after burn in on mainnet (4417, 4423, 4425) on a variety of hw and CL configurations |
|
Thanks @jflo for the review, I will implement your suggestion in a future PR |
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…utable transactions (hyperledger#4425) * Add more tracing logs to transaction pool * Prevent adding non executable transactions and evict based on age * Move sender account in TransactionsForSenderInfo * Implement a size expiration cache for lowest invalid nonce for sender Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR is built on top of #4413 which was used to investigate the transaction pool, with the result that currently we keep many transactions that are not possible to include in a block, because a transaction with a lower nonce is missing or invalid.
To avoid that issues first we now remember (in a cache) that that sender has an invalid transaction, and we do not accept transactions with higher nonce from that sender, of course if a replacement for the invalid transaction is sent it is accepted.
The eviction when the pool is full has changed in order to pick the sender of the oldest transaction in the pool, and the evict the transaction with the higher nonce for that sender, so no gaps in the nonce list for that sender are created.
Fixed Issue(s)
fixes #4401
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog