-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update consensus_FAQ.md: Changed Text mentioning "Three" to "Two" algorithms #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution, but it's only a read-only mirror. You can go to Gerrit and submit the patch. |
ghost
closed this
Oct 21, 2016
ghost
pushed a commit
that referenced
this pull request
Jan 21, 2018
This changes the main Vagrant mount point to hyperledger to provide access to all present hyperledger repositories, including fabric-samples. This will give access to new repos as they are added without requiring a modification of the Vagrantfile every time. Patch-set #1: adds fabric-samples to the list of mounted volumes if it exists Patch-set #2: fixes commit message Patch-set #3: changes strategy, mounting the parent directory to be future proof Patch-set #4: removed unrelated changes committed by error Change-Id: If126bd9d6d8806f149a0e6bacb1d8d34875f7ba4 Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
ghost
pushed a commit
that referenced
this pull request
Feb 18, 2019
This is the fourth of four (4/4) sub-tasks that focus on the "green" path of consensus-type migration from Kafka to Raft. By "green" we mean that there are no failures or aborts along the way. The 4 sub-tasks are staged in a way that minimizes dependencies between them. In this sub-task we introduce changes to the etcd/raft-base OSNs such that they can restart from a ledger that was started as Kafka, migrated, and restarted. This change concludes all the changes needed to implement the green path on the "Raft" side. See respective JIRA item for further details. Change-Id: I5b408e1cfcb8cf42c39bed4df6c5496792175ef0 Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost
pushed a commit
that referenced
this pull request
Feb 18, 2019
ghost
pushed a commit
that referenced
this pull request
Mar 4, 2019
This is the fourth of four (4/4) sub-tasks that focus on the "green" path of consensus-type migration from Kafka to Raft. By "green" we mean that there are no failures or aborts along the way. The 4 sub-tasks are staged in a way that minimizes dependencies between them. In this sub-task we introduce changes to the etcd/raft-base OSNs such that they can restart from a ledger that was started as Kafka, migrated, and restarted. This change concludes all the changes needed to implement the green path on the "Raft" side. See respective JIRA item for further details. Change-Id: I5b408e1cfcb8cf42c39bed4df6c5496792175ef0 Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost
pushed a commit
that referenced
this pull request
Apr 11, 2019
In preparation to the alternative migration design (v2), revert some of the commits already merged. Kafka to Raft migration v1 - cleanup #4 Remove migration package clean commits: 9002e75 a0a9189 2d924d0 15bf213 Change-Id: I4c222852f7f686d121b4f95e5c00b4d7f22d56a8 Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost
pushed a commit
that referenced
this pull request
Jun 7, 2019
In preparation to the alternative migration design (v2), revert some of the commits already merged. Kafka to Raft migration v1 - cleanup #4 Remove migration package clean commits: 9002e75 a0a9189 2d924d0 15bf213 Change-Id: I4c222852f7f686d121b4f95e5c00b4d7f22d56a8 Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost
pushed a commit
that referenced
this pull request
Jun 7, 2019
ZhAnGeek
pushed a commit
to ZhAnGeek/fabric
that referenced
this pull request
Oct 16, 2021
andrew-coleman
pushed a commit
to andrew-coleman/fabric
that referenced
this pull request
Jun 20, 2022
…ft_blockpuller add unit tests
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The text says that there are three consensus implementations but actually there are only two implementations as of now.
Motivation and Context
The change improves the documentation.
Signed-off-by: Sumit Mehrotra sumit@sumitmehrotra.com