Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed edits / clarifications #5

Closed
wants to merge 1 commit into from
Closed

Proposed edits / clarifications #5

wants to merge 1 commit into from

Conversation

joshhus
Copy link
Contributor

@joshhus joshhus commented Oct 24, 2016

Description

See lines 3-14 as a sample / suggestions.

Motivation and Context

Clarify meaning and readability for all readers. Provide a sound basis for eventual external documentation.

Fixes #

How Has This Been Tested?

Reviewed changes in file comparison only.

Checklist:

  • I have added a Signed-off-by.
  • I have either added documentation to cover my changes or this change requires no new documentation.
  • I have either added unit tests to cover my changes or this change requires no new tests.
  • [] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Joshua Horton - joshh@us.ibm.com

For lines 3-14.

If the authors approve and agree, I will continue.

@joshhus
Proposed edits / clarifications
5e30d33 
For lines 3-14. 

If the authors approve and agree, I will continue.
@ghost
Copy link

ghost commented Oct 24, 2016

this is a read-only mirror. please submit code to https://gerrit.hyperledger.org/

@ghost ghost closed this Oct 24, 2016
@joshhus
Copy link
Contributor Author

joshhus commented Oct 24, 2016

I don't see this document on gerrit ... thanks for any help ...

@ghost
Copy link

ghost commented Oct 24, 2016

@joshhus here is the file in gitweb: https://gerrit.hyperledger.org/r/gitweb?p=fabric.git;a=tree;f=proposals/r1;h=b7df07b533023810a171024daf4b580d8d0b5ed5;hb=HEAD

you would need to check out the repo here: https://gerrit.hyperledger.org/r/#/admin/projects/fabric and make your edits, pushing them to gerrit

here is a walkthrough for zephyrproject which is much the same WRT setting up an LFID, adding ssh keys, etc:
https://www.zephyrproject.org/doc/1.1.0/collaboration/code/gerrit_accounts.html

feel free to ask on slack - https://slack.hyperledgerproject.org/ - I'm @ry there, feel free to ask me directly, or discuss in #fabric

one note: when you set up your LFID do not use social logins the first time, create the account and you can add social logins later

ghost pushed a commit that referenced this pull request Apr 26, 2018
@lehors
[FAB-4458] Incremental downloads in bootstrap script
9b83ea0 
When a network failure occurs, bootstrap.sh will restart the download
using the curl -C option which provides resuming capabilities. The
Nexus repo, however, has some limitations which cause curl to return
error codes even when the download succeeds (see comments in the script).
They have been treated in the script. This will allow failed downloads
to be treated automatically, making the documentation leaner. Several
scenarios were tested in RHEL 7.4 and Ubuntu 14.04.

Patch-set #5: Rebase + incremental download of Fabric-CA binaries
+ handling of 404 errors (requested file isn't available)

Change-Id: If8e4da57b2c19431c2d098590ff3bbd87dfa83d6
Signed-off-by: Phillip Viana <phillip.l.viana@gmail.com>
Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
ghost pushed a commit that referenced this pull request May 27, 2019
@tock-ibm
FAB-15511 Kafka2Raft-V1 cleanup #5
416b144 
Clean dead code from multichannel/registrar_test.go

Change-Id: Ib734da20f4609b5aad44e1778ede032165f18c97
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request May 27, 2019
@yacovm
Merge "FAB-15511 Kafka2Raft-V1 cleanup #5"
54bec7f
ghost pushed a commit that referenced this pull request Jun 7, 2019
@tock-ibm
FAB-15511 Kafka2Raft-V1 cleanup #5
3fd414c 
Clean dead code from multichannel/registrar_test.go

Change-Id: Ib734da20f4609b5aad44e1778ede032165f18c97
Signed-off-by: Yoav Tock <tock@il.ibm.com>
ghost pushed a commit that referenced this pull request Jun 7, 2019
Merge changes Ib734da20,I4c222852,I52a1283e,Ic7274401,I0eefdaed into …
09e245b 
…release-1.4

* changes:
  FAB-15511 Kafka2Raft-V1 cleanup #5
  FAB-15045 Mig-v1 cleanup #4
  FAB-15044 Mig-v1 cleanup #3
  FAB-15043 Mig-v1 cleanup #2
  FAB-14700  Kafka2Raft validate broadcast
cendhu referenced this pull request in cendhu/fabric Dec 11, 2019
@tock-ibm @cendhu
FAB-15511 Kafka2Raft-V1 cleanup #5
e51e7d8 
Clean dead code from multichannel/registrar_test.go

Change-Id: Ib734da20f4609b5aad44e1778ede032165f18c97
Signed-off-by: Yoav Tock <tock@il.ibm.com>
andrew-coleman pushed a commit to andrew-coleman/fabric that referenced this pull request Jul 1, 2022
@yacovm
Merge pull request hyperledger#5 from shivdeep-singh-ibm/temp_draft_b…
54c4c8d 
…ft_blockpuller

add blockfetcher to consensus
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshhus