Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return response with more specific error description #1454

Closed
rkharisov opened this issue Sep 21, 2021 · 1 comment · Fixed by #1527
Closed

Return response with more specific error description #1454

rkharisov opened this issue Sep 21, 2021 · 1 comment · Fixed by #1527
Assignees
@s8sato
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@rkharisov
Copy link

Precondition: Some error happened during query execution

Expected: Server responds with 4XX or 2XX (not 500) and details of rejection will be described in body. Additionally rejection can be logged with trace level

Current: Server responds with 500 with message "Failed to execute query", no records in logs
@rkharisov rkharisov added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 21, 2021
@rkharisov rkharisov changed the title Return response with more specific erorrs Return response with more specific error description Sep 21, 2021
@s8sato s8sato self-assigned this Oct 5, 2021
@s8sato

This comment has been minimized.

Sign in to view
@appetrosyan appetrosyan linked a pull request Oct 19, 2021 that will close this issue
Fix query error response with specific status code and hints. Close #1454 #1527
Merged
@s8sato s8sato mentioned this issue Oct 22, 2021
Merged
s8sato added a commit to s8sato/iroha that referenced this issue Oct 22, 2021
@s8sato
Fix query error response with specific status code and hints. Close h…
d0a5d28 
…yperledger#1454

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
s8sato added a commit that referenced this issue Oct 22, 2021
@s8sato
Fix query error response with specific status code and hints. Close #…
f34d0be 
…1454 (#1527)

* Fix query error response with specific status code and hints. Close #1454

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Fix a bit `CONTRIBUTING.md`

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

* Fix with reviews

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s8sato s8sato

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix query error response with specific status code and hints. Close #1454 s8sato/iroha
2 participants
@s8sato @rkharisov