Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grant and Revoke roles should emit RoleGranted/RoleRevoked events. #2257

Closed
omkar-mohanty opened this issue May 24, 2022 · 1 comment
Closed

Grant and Revoke roles should emit RoleGranted/RoleRevoked events. #2257

omkar-mohanty opened this issue May 24, 2022 · 1 comment
Assignees
@Arjentix
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@omkar-mohanty
Copy link
Contributor

omkar-mohanty commented May 24, 2022 •
edited
Loading

Following from #2007 as of now Revoke role (in smartcontracts/isi/account.rs) emits PermissionRemoved event which is misleading since roles are a collection of permissions. Refactor the code so that Revoke role emits RoleRemoved and PermissionRemoved events.
omkar-mohanty added a commit to omkar-mohanty/iroha that referenced this issue May 26, 2022
@omkar-mohanty
[feature] hyperledger#2257: Revoke<Role> emits RoleRevoked event
9ea6d33 
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
@omkar-mohanty omkar-mohanty mentioned this issue May 27, 2022
Merged
omkar-mohanty added a commit to omkar-mohanty/iroha that referenced this issue May 28, 2022
@omkar-mohanty
[feature] hyperledger#2257: Revoke<Role> emits RoleRevoked event
d7e167e 
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
omkar-mohanty added a commit to omkar-mohanty/iroha that referenced this issue May 29, 2022
@omkar-mohanty
[feature] hyperledger#2257: Revoke<Role> emits RoleRevoked event
aed6a5a 
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
omkar-mohanty added a commit to omkar-mohanty/iroha that referenced this issue May 30, 2022
@omkar-mohanty
[feature] hyperledger#2257: Revoke<Role> emits RoleRevoked event
cf7aa94 
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
omkar-mohanty added a commit to omkar-mohanty/iroha that referenced this issue May 30, 2022
@omkar-mohanty
[feature] hyperledger#2257: Revoke<Role> emits RoleRevoked event
a19061c 
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
omkar-mohanty added a commit to omkar-mohanty/iroha that referenced this issue May 30, 2022
@omkar-mohanty
[feature] hyperledger#2257: Revoke<Role> emits RoleRevoked event
309b1e9 
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
appetrosyan pushed a commit that referenced this issue May 31, 2022
@omkar-mohanty
[feature] #2257: Revoke<Role> emits RoleRevoked event (#2264)
5ddb17c 
Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
BAStos525 pushed a commit to BAStos525/soramitsu-iroha that referenced this issue Jul 8, 2022
@omkar-mohanty @BAStos525
[feature] hyperledger#2257: Revoke<Role> emits RoleRevoked event (hyp…
8b11b74 
…erledger#2264)

Signed-off-by: omkar-mohanty <franzohouser@gmail.com>
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
@appetrosyan appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 12, 2022
@Arjentix Arjentix self-assigned this Dec 19, 2022
@Arjentix
Copy link
Contributor

Closed as duplicate of #2280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
Iroha 2.0
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appetrosyan @Arjentix @omkar-mohanty