[BUG] Any information hasn't been propagated to the client when a client tries to register the duplication domain or account.

[AlexStroke]

GIT commit hash

4936869

Minimum working example

1. Install scripts/test_env.sh setup
2. Register domain./iroha_client_cli domain register --id="looking_glass"
3. Try to register the same again ./iroha_client_cli domain register --id="looking_glass"

Expected behaviour

Error: This domain already exist

Actual behaviour

Absent any information when a client tries to register the same domain.

alexstrokelive@Aleksandrs-MacBook-Pro test % ./iroha_client_cli domain register --id="looking_glass"
User: alice@wonderland
{"PUBLIC_KEY":"ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0","PRIVATE_KEY":{"digest_function":"ed25519","payload":"9ac47abf59b356e0bd7dcbbbb4dec080e302156a48ca907e47cb6aea1d32719e7233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"},"ACCOUNT_ID":{"name":"alice","domain_id":{"name":"wonderland"}},"BASIC_AUTH":{"web_login":"mad_hatter","password":"ilovetea"},"TORII_API_URL":"http://127.0.0.1:8080","TORII_TELEMETRY_URL":"127.0.0.1:8180","TRANSACTION_TIME_TO_LIVE_MS":100000,"TRANSACTION_STATUS_TIMEOUT_MS":10000,"TRANSACTION_LIMITS":{"max_instruction_number":4096,"max_wasm_size_bytes":4194304},"ADD_TRANSACTION_NONCE":false}
alexstrokelive@Aleksandrs-MacBook-Pro test % ./iroha_client_cli domain register --id="looking_glass"
User: alice@wonderland
{"PUBLIC_KEY":"ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0","PRIVATE_KEY":{"digest_function":"ed25519","payload":"9ac47abf59b356e0bd7dcbbbb4dec080e302156a48ca907e47cb6aea1d32719e7233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"},"ACCOUNT_ID":{"name":"alice","domain_id":{"name":"wonderland"}},"BASIC_AUTH":{"web_login":"mad_hatter","password":"ilovetea"},"TORII_API_URL":"http://127.0.0.1:8080","TORII_TELEMETRY_URL":"127.0.0.1:8180","TRANSACTION_TIME_TO_LIVE_MS":100000,"TRANSACTION_STATUS_TIMEOUT_MS":10000,"TRANSACTION_LIMITS":{"max_instruction_number":4096,"max_wasm_size_bytes":4194304},"ADD_TRANSACTION_NONCE":false}

Operating system

MacOS

LibC type and version

No response

Current environment

Source code build

Logs in JSON format

Log contents

2022-09-29T16:37:48.786192Z  INFO iroha: Hyperledgerいろは2にようこそ！
2022-09-29T16:37:48.786339Z  INFO iroha: (translation) Welcome to Hyperledger Iroha 2!
2022-09-29T16:37:48.796098Z  INFO iroha: Starting peer listen_addr=127.0.0.1:1337
2022-09-29T16:37:48.796156Z  INFO iroha_p2p::network: Binding listener listen_addr=127.0.0.1:1337
2022-09-29T16:37:48.796303Z  INFO iroha_p2p::network: Starting network actor listen_addr=127.0.0.1:1337
2022-09-29T16:37:48.805047Z  INFO iroha_core::kura: Loaded 7 blocks at init.
2022-09-29T16:37:48.809095Z  INFO iroha_core::sumeragi::fault: Starting Sumeragi
2022-09-29T16:37:48.809184Z  INFO iroha: Starting Iroha
2022-09-29T16:37:48.809197Z  INFO iroha_core::sumeragi::fault: Connecting peer peer_to_be_connected.address=127.0.0.1:1338
2022-09-29T16:37:48.809536Z  INFO iroha_core::sumeragi::fault: Connecting peer peer_to_be_connected.address=127.0.0.1:1339
2022-09-29T16:37:48.809571Z  INFO iroha_core::sumeragi::fault: Connecting peer peer_to_be_connected.address=127.0.0.1:1340
2022-09-29T16:37:48.810674Z  INFO handle{self=Network { peers: 0 } msg=Connected(Id { address: "127.0.0.1:61221", public_key: { digest: ed25519, payload: 8E351A70B6A603ED285D666B8D689B680865913BA03CE29FB7D13A166C4E7F1F } }, 7662060517175911240)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=5 count.peers=1
2022-09-29T16:37:48.810755Z  INFO handle{self=Network { peers: 1 } msg=Connected(Id { address: "127.0.0.1:61225", public_key: { digest: ed25519, payload: CC25624D62896D3A0BFD8940F928DC2ABF27CC57CEFEB442AA96D9081AAE58A1 } }, 18315721206597383598)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=4 count.peers=2
2022-09-29T16:37:48.810823Z  INFO handle{self=Network { peers: 2 } msg=Connected(Id { address: "127.0.0.1:61228", public_key: { digest: ed25519, payload: FACA9E8AA83225CB4D16D67F27DD4F93FC30FFA11ADC1F5C88FD5495ECC91020 } }, 4695087213541461910)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=3 count.peers=3
2022-09-29T16:37:48.811796Z  INFO handle{self=Network { peers: 3 } msg=Connected(Id { address: "127.0.0.1:1338", public_key: { digest: ed25519, payload: CC25624D62896D3A0BFD8940F928DC2ABF27CC57CEFEB442AA96D9081AAE58A1 } }, 14772424299433031910)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=2 count.peers=3
2022-09-29T16:37:48.812395Z  INFO handle{self=Network { peers: 3 } msg=Connected(Id { address: "127.0.0.1:1340", public_key: { digest: ed25519, payload: 8E351A70B6A603ED285D666B8D689B680865913BA03CE29FB7D13A166C4E7F1F } }, 8816577560745799765)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=1 count.peers=3
2022-09-29T16:37:48.812468Z  INFO handle{self=Network { peers: 3 } msg=Connected(Id { address: "127.0.0.1:1339", public_key: { digest: ed25519, payload: FACA9E8AA83225CB4D16D67F27DD4F93FC30FFA11ADC1F5C88FD5495ECC91020 } }, 191688110400873095)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=0 count.peers=3
2022-09-29T16:38:20.931816Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:61235}: warp::filters::trace: processing request
2022-09-29T16:38:20.932579Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:61235}: warp::filters::trace: finished processing with success status=200
2022-09-29T16:38:21.035461Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:61237}: warp::filters::trace: processing request
2022-09-29T16:38:21.036605Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:61237}: warp::filters::trace: finished processing with success status=200
2022-09-29T16:38:21.101000Z  INFO iroha_core::sumeragi::fault: Validating block block_hash=e1cfce05c7005ffb0835694f3d052c9bafabf8a40eea05a5fac30dc2f3246741
2022-09-29T16:38:21.101544Z  WARN iroha_core::block: Transaction validation failed reason=Transaction rejected due to failure in instruction execution caused_by=Some(InstructionExecutionFail { instruction: Register(RegisterBox { object: EvaluatesTo { expression: Raw(Identifiable(NewDomain(NewDomain { id: Id { name: "looking_glass" }, logo: None, metadata: Metadata { map: {} } }))), _value_type: PhantomData } }), reason: "Repetition" })
2022-09-29T16:38:21.101637Z  INFO iroha_core::sumeragi::fault: Created a block peer_role=Leader block_hash=99468fad250b224379f652a52065cf9c10a3d64f96948162733a4f64269c4962
2022-09-29T16:38:21.111786Z  INFO handle:commit_block: iroha_core::sumeragi::fault: Committing block prev_peer_role=Leader new_peer_role=ProxyTail new_block_height=8 block_hash=99468fad250b224379f652a52065cf9c10a3d64f96948162733a4f64269c4962
2022-09-29T16:38:22.872397Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:61238}: warp::filters::trace: processing request
2022-09-29T16:38:22.872789Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:61238}: warp::filters::trace: finished processing with success status=200
2022-09-29T16:38:22.978038Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:61239}: warp::filters::trace: processing request
2022-09-29T16:38:22.979027Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:61239}: warp::filters::trace: finished processing with success status=200
2022-09-29T16:38:23.116336Z  INFO iroha_core::sumeragi::fault: Forwarding tx to leader peer_addr=127.0.0.1:1337 peer_role=ProxyTail leader_addr=127.0.0.1:1340 tx_hash=a84e059cd55c0d3d1a2fff13e4d461a9ee60b36e8b7b97774326db7555a97ab5
2022-09-29T16:38:23.329246Z  INFO handle: iroha_core::sumeragi::message: Received a vote for block peer_role=ProxyTail block_hash=e68c43d96bbc90fe9be2038cb10322352b4de3a9f7228519779e9693de01f303 valid_signatures_count=2 required_signatures_count=2
2022-09-29T16:38:23.329630Z  INFO handle: iroha_core::sumeragi::message: Block reached required number of votes peer_role=ProxyTail block_hash=e68c43d96bbc90fe9be2038cb10322352b4de3a9f7228519779e9693de01f303
2022-09-29T16:38:23.330681Z  INFO handle:commit_block: iroha_core::sumeragi::fault: Committing block prev_peer_role=ProxyTail new_peer_role=ObservingPeer new_block_height=9 block_hash=e68c43d96bbc90fe9be2038cb10322352b4de3a9f7228519779e9693de01f303
2022-09-29T16:38:23.838547Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:61240}: warp::filters::trace: processing request
2022-09-29T16:38:23.839253Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:61240}: warp::filters::trace: finished processing with success status=200
2022-09-29T16:38:23.943527Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:61241}: warp::filters::trace: processing request
2022-09-29T16:38:23.944614Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:61241}: warp::filters::trace: finished processing with success status=200
2022-09-29T16:38:24.125860Z  INFO iroha_core::sumeragi::fault: Forwarding tx to leader peer_addr=127.0.0.1:1337 peer_role=ObservingPeer leader_addr=127.0.0.1:1338 tx_hash=9491165682a51695f7df6d694ae47defcb4fe6171dcfb01e80cce268e2463abb
2022-09-29T16:38:24.348596Z  INFO handle:commit_block: iroha_core::sumeragi::fault: Committing block prev_peer_role=ObservingPeer new_peer_role=ObservingPeer new_block_height=10 block_hash=2fd59da6d94bf01c342e341b210e8333bd28fc3519b973d3b20f66c41a307138

Who can help?

@astrokov7

[appetrosyan]

Logs contain a clue:

2022-09-29T16:38:21.101544Z  WARN iroha_core::block: Transaction validation failed reason=Transaction rejected due to failure in instruction execution caused_by=Some(InstructionExecutionFail { instruction: Register(RegisterBox { object: EvaluatesTo { expression: Raw(Identifiable(NewDomain(NewDomain { id: Id { name: "looking_glass" }, logo: None, metadata: Metadata { map: {} } }))), _value_type: PhantomData } }), reason: "Repetition" })

This should have been propagated back to the client, but wasn't.