[refactor]: improve error messages on configuration failure. #2892

appetrosyan · 2022-10-20T07:03:19Z

Signed-off-by: Aleksandr Petrosyan a-p-petrosyan@yandex.ru

Description of the Change

Improved error messages in cases where configuration failed to get parsed.

Issue

None

Benefits

Better UX.

Possible Drawbacks

None

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

config/src/client.rs

config/src/iroha.rs

codecov · 2022-10-20T07:33:11Z

Codecov Report

Merging #2892 (04623c9) into iroha2-dev (a16d9c3) will decrease coverage by 5.39%.
The diff coverage is 76.46%.

❗ Current head 04623c9 differs from pull request most recent head 7d4f632. Consider uploading reports for the commit 7d4f632 to get more accurate results

@@              Coverage Diff               @@
##           iroha2-dev    #2892      +/-   ##
==============================================
- Coverage       67.61%   62.21%   -5.40%     
==============================================
  Files             140      168      +28     
  Lines           26173    29942    +3769     
==============================================
+ Hits            17696    18628     +932     
- Misses           8477    11314    +2837

Impacted Files	Coverage Δ
actor/src/actor_id.rs	`90.00% <ø> (ø)`
actor/src/deadlock.rs	`85.93% <ø> (-14.07%)`	⬇️
cli/derive/src/lib.rs	`92.30% <ø> (+17.58%)`	⬆️
cli/src/event.rs	`0.00% <ø> (-41.87%)`	⬇️
cli/src/main.rs	`1.09% <0.00%> (-0.26%)`	⬇️
cli/src/stream.rs	`0.00% <ø> (-81.40%)`	⬇️
client/src/http.rs	`47.82% <ø> (ø)`
client/src/http_default.rs	`40.17% <0.00%> (-20.01%)`	⬇️
client_cli/src/main.rs	`0.27% <0.00%> (+0.01%)`	⬆️
config/base/src/runtime_upgrades.rs	`49.42% <0.00%> (ø)`
... and 228 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

config/src/client.rs

Co-authored-by: Ilia Churin <churin.ilya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [ci]: Add cargo caching 1 Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [ci]: Add cargo caching 2 Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [ci]: try cargo cache Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [feature] hyperledger#2280: Produce permission events when role is granted/revoked Signed-off-by: Shanin Roman <shanin1000@yandex.ru> [documentation]: Move some docs to the tutorial repository Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> [documentation]: Review punctuation (hyperledger#2872) Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> [fix] hyperledger#2804, hyperledger#2863: `iroha_client_cli` submit transaction blocking Signed-off-by: Shanin Roman <shanin1000@yandex.ru> [refactor]: improve error messages on configuration failure. (hyperledger#2892) Co-authored-by: Ilia Churin <churin.ilya@gmail.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru> [documentation]: Remove outdated doc files Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> [feature] hyperledger#2508: Add a new client CLI subcommand that accepts wasm Signed-off-by: Vladimir Pesterev <pesterev@pm.me> [feature] hyperledger#2889: Add block streaming support into `iroha_client` Signed-off-by: Shanin Roman <shanin1000@yandex.ru> [fix] hyperledger#2880: Fix block streaming Signed-off-by: Shanin Roman <shanin1000@yandex.ru> [fix] hyperledger#2880: Close websocket connection properly Signed-off-by: Shanin Roman <shanin1000@yandex.ru> [fix] #0000: Fix `panic_on_invalid_genesis.sh` Signed-off-by: Shanin Roman <shanin1000@yandex.ru> [ci]: gggg Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [ci]: sssss Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [ci]: bbbb Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [ci]: Add cargo chef caching Signed-off-by: BAStos525 <jungle.vas@yandex.ru> [ci]: Add cargo chef caching Signed-off-by: BAStos525 <jungle.vas@yandex.ru>

…dger#2892) Co-authored-by: Ilia Churin <churin.ilya@gmail.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

Co-authored-by: Ilia Churin <churin.ilya@gmail.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

…dger#2892) Co-authored-by: Ilia Churin <churin.ilya@gmail.com> Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

[refactor]: improve error messages on configuration failure.

04623c9

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

appetrosyan requested review from s8sato, mversic, Arjentix, SamHSmith, QuentinI, outoftardis, ilchu, pesterev and Erigara as code owners October 20, 2022 07:03

github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 20, 2022

appetrosyan added the UI Something about the interface label Oct 20, 2022

Erigara assigned appetrosyan and Erigara Oct 20, 2022

Erigara previously approved these changes Oct 20, 2022

View reviewed changes

ilchu reviewed Oct 20, 2022

View reviewed changes

config/src/client.rs Show resolved Hide resolved

config/src/client.rs Outdated Show resolved Hide resolved

config/src/iroha.rs Show resolved Hide resolved

outoftardis reviewed Oct 20, 2022

View reviewed changes

config/src/client.rs Show resolved Hide resolved

config/src/client.rs Outdated Show resolved Hide resolved

config/src/client.rs Outdated Show resolved Hide resolved

appetrosyan dismissed Erigara’s stale review via cb289db October 20, 2022 07:41

appetrosyan and others added 2 commits October 20, 2022 11:41

Update config/src/client.rs

cb289db

Co-authored-by: Ilia Churin <churin.ilya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

Apply suggestions from code review

7d4f632

Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>

ilchu approved these changes Oct 20, 2022

View reviewed changes

Erigara approved these changes Oct 20, 2022

View reviewed changes

appetrosyan merged commit faf0bc9 into hyperledger:iroha2-dev Oct 20, 2022

appetrosyan deleted the iroha2-dev branch October 20, 2022 07:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[refactor]: improve error messages on configuration failure. #2892

[refactor]: improve error messages on configuration failure. #2892

appetrosyan commented Oct 20, 2022

codecov bot commented Oct 20, 2022 •

edited

Loading

[refactor]: improve error messages on configuration failure. #2892

[refactor]: improve error messages on configuration failure. #2892

Conversation

appetrosyan commented Oct 20, 2022

Description of the Change

Issue

Benefits

Possible Drawbacks

codecov bot commented Oct 20, 2022 • edited Loading

Codecov Report

codecov bot commented Oct 20, 2022 •

edited

Loading