Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to check genesis.json in CI overcoming cargo builds reproducibility problem #3168

Closed
Arjentix opened this issue Feb 17, 2023 · 1 comment
Closed

Find a way to check genesis.json in CI overcoming cargo builds reproducibility problem #3168

Arjentix opened this issue Feb 17, 2023 · 1 comment
Assignees
@Erigara
Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@Arjentix
Copy link
Contributor

Originally posted by me here.

After the merge of #3106 there will be a problem, that local kagami will generate different genesis.json rather than kagami in CI. This is caused by cargo builds are not reproducibile problem, which results in generating different WASM code for validator, which is inserted in our genesis.json.

We need to find a way to properly check our genesis in CI.
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST CI labels Feb 17, 2023
@Arjentix
Copy link
Contributor Author

One of disscussed solutions.

Store a path to a wasm blob and some kind of build-hash inside genesis. Build-hash should take macros, changes in dependencies and etc into account. In CI don't check the exact wasm blob file

@Arjentix Arjentix mentioned this issue Feb 17, 2023
Merged
@Erigara Erigara mentioned this issue Mar 7, 2023
Merged
@appetrosyan appetrosyan mentioned this issue Mar 14, 2023
Open
@Erigara Erigara assigned Erigara and unassigned Erigara Apr 24, 2023
Erigara added a commit to Erigara/iroha that referenced this issue Apr 28, 2023
@Erigara
[feature] hyperledger#3168: Provide genesis validator in separate file
3ffa580 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara mentioned this issue Apr 28, 2023
Merged
5 tasks
Erigara added a commit to Erigara/iroha that referenced this issue Apr 28, 2023
@Erigara
[feature] hyperledger#3168: Provide genesis validator in separate file
1330dde 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue Apr 28, 2023
@Erigara
[feature] hyperledger#3168: Provide genesis validator in separate file
00b28f7 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue May 2, 2023
@Erigara
[feature] hyperledger#3168: Provide genesis validator in separate file
e523354 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit to Erigara/iroha that referenced this issue May 2, 2023
@Erigara
[feature] hyperledger#3168: Provide genesis validator in separate file
4b08df8 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Erigara added a commit that referenced this issue May 2, 2023
@Erigara
[feature] #3168: Provide genesis validator in separate file
6daae99 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara closed this as completed May 2, 2023
appetrosyan pushed a commit that referenced this issue Jun 5, 2023
@Erigara @appetrosyan
[feature] #3168: Provide genesis validator in separate file
1114448 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic pushed a commit that referenced this issue Oct 17, 2023
@Erigara @mversic
[feature] #3168: Provide genesis validator in separate file
d5963e2 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arjentix @Erigara