Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip children of missing properties #56

Conversation

thewilkybarkid
Copy link

Bit of a brute-force approach, but this stops the children of missing properties from being checked in case they are strict (and would then always fail in strict mode).

Refs https://github.com/hypermedia-app/hypertest/issues/70 and libero/article-store#184.

@commit-lint
Copy link

commit-lint bot commented Jan 22, 2020

Bug Fixes

  • skip children of missing properties (2f5a41e)

Contributors

@thewilkybarkid

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage      87%   87.02%   +0.02%     
==========================================
  Files          35       35              
  Lines         477      478       +1     
  Branches      103      103              
==========================================
+ Hits          415      416       +1     
  Misses         62       62
Impacted Files Coverage Δ
...tor-e2e/lib/steps/representation/property/index.ts 98.11% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f4db0...2f5a41e. Read the comment docs.

@tpluscode
Copy link
Member

Have to reject this change because mutating the state will affect the result if a step is visited multiple times

@tpluscode tpluscode closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants