Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Uses Iri as NamedNode value and allow individual article retrieval #184

Merged
merged 41 commits into from
Jan 23, 2020

Conversation

nlisgo
Copy link
Member

@nlisgo nlisgo commented Jan 16, 2020

This is a followup to: #181

It uses an Iri as the NamedNode value and allwos the retrieval of an individual article.

@nlisgo nlisgo changed the title Articles dereferenceable cont Uses Iri as NamedNode value and allow individual article retrieval Jan 16, 2020
@giorgiosironi
Copy link
Member

Screenshot_2020-01-16 Uses Iri as NamedNode value and allow individual article retrieval by nlisgo · Pull Request #184 · li

If someone edits the description of an issue you have created, your spirit will be evoked.

@giorgiosironi
Copy link
Member

Now that merge of #181 is possible, should be rebased to remove the changes that are already in.

@thewilkybarkid thewilkybarkid added the 🆕 Feature A new feature label Jan 21, 2020
test/context.ts Outdated Show resolved Hide resolved
@thewilkybarkid
Copy link
Contributor

I've pushed 0d43a9a which does contradict #184 (comment). There's complexity in the article 'route' having to know whether to lookup or not (could be extracted though), and the dependency cycle (#184 (comment); again could be solved by extracting).

Not 100% happy with this, means having to add another route if the format is ever changed. Will continue to think.

@nlisgo
Copy link
Member Author

nlisgo commented Jan 23, 2020

Not 100% happy with this, means having to add another route if the format is ever changed. Will continue to think.

Happy to kick this problem down the road. We don't need to solve it now.

@thewilkybarkid
Copy link
Contributor

Think this is all good now, just need to resolve/bypass the Hypertest problem.

@thewilkybarkid
Copy link
Contributor

hypermedia-app/hydra-validator#57 should fix Hypertest.

@thewilkybarkid thewilkybarkid merged commit c25a094 into libero:master Jan 23, 2020
@nlisgo nlisgo deleted the articles-dereferenceable-cont branch January 23, 2020 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🆕 Feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants