Change blanknodes to namednodes #181
Conversation
|
@giorgiosironi I would like this to be considered for release. I know it doesn't address all of the todo items but it adds enough value in my opinion. The next piece of work will be to improve the identifier to include the I believe this will be enough to unblock the database persistence work. |
| @@ -28,7 +28,7 @@ export default (): AppMiddleware => ( | |||
| throw new createHttpError.BadRequest(`Article must have at least one ${termToString(schema('name'))}`); | |||
| } | |||
|
|
|||
| const newId = blankNode(uniqueString()); | |||
| const newId = namedNode(uniqueString()); | |||
There was a problem hiding this comment.
The documentation says this should be an IRI, but we have good reasons to use host-free values.
There was a problem hiding this comment.
Checking NamedNode basic requirements I think this should go ahead.
The other tasks in libero/publisher#367 however still need to be followed up before persistence can be introduced as the whole ticket has been created as a blocker (also I see that at the bare minimum identifiers like /articles/... should be stable before they start to get persisted).
|
Found out this couldn't be merged by @nlisgo because the branch protection on |
The aim of this PR is to introduce the smallest amount of changes to swap out
BlankNodesforNamedNodes.