This repository has been archived by the owner on May 14, 2020. It is now read-only.
Extract test middleware that always throws an error #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
added
the
📦 Refactor
thewilkybarkid
commented
Jan 22, 2020
| import { ExtendableContext } from 'koa'; | ||
| import { Middleware } from 'koa-compose'; | ||
| import { AppContext } from '../src/app'; | ||
|
|
||
| export type NextMiddleware<CustomT extends ExtendableContext = AppContext> = | ||
| (context: CustomT) => Promise<void>; | ||
|
|
||
| export const throwingNext = <CustomT extends ExtendableContext = AppContext> | ||
| (error: UnknownError = new Error()): NextMiddleware<CustomT> => (): never => { |
There was a problem hiding this comment.
Changed return type to never, and removed async (seems to make no difference).
There was a problem hiding this comment.
Given there's no await inside roughly I would expect async not to be required, but who knows what kind of type checking is going on
giorgiosironi
approved these changes
Jan 22, 2020
|
Uh, conflicts block the build at the moment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the middleware used by the error handler test that always throws an error so it can be used elsewhere (#184).