Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coveralls.io integration #1196

Closed
jarifibrahim opened this issue Jan 15, 2020 · 4 comments · Fixed by #1219
Closed

Remove coveralls.io integration #1196

jarifibrahim opened this issue Jan 15, 2020 · 4 comments · Fixed by #1219
Labels
area/tools Issues related to maintenance tools and CLI. exp/beginner Something most people could solve. good first issue These are simple issues that can be picked up by new contributors kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.

Comments

@jarifibrahim
Copy link
Contributor

Coverall.io integration fails frequently which leads to a failed build. We should remove it.

See example build https://travis-ci.org/dgraph-io/badger/jobs/636936733?utm_medium=notification&utm_source=github_status

https://github.com/dgraph-io/badger/blob/5870b7b1975e031549f8a3d4309335f6b03f0fa4/.travis.yml#L24-L29
@jarifibrahim jarifibrahim added kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. area/tools Issues related to maintenance tools and CLI. exp/beginner Something most people could solve. good first issue These are simple issues that can be picked up by new contributors labels Jan 15, 2020
@jarifibrahim jarifibrahim mentioned this issue Jan 15, 2020
Merged
@janisz
Copy link
Contributor

janisz commented Jan 22, 2020

How about replacing it with https://codecov.io/
Integration is much simpler

after_success:
- bash <(curl -s https://codecov.io/bash)

@vardhanapoorv
Copy link
Contributor

@janisz the code coverage isn't a reliable metric, hence it would be better to remove it.
Feel free to send a PR.

janisz added a commit to janisz/badger that referenced this issue Feb 13, 2020
@janisz
Remove coveralls
a345867 
Fixes: hypermodeinc#1196
@janisz janisz mentioned this issue Feb 13, 2020
Merged
@janisz
Copy link
Contributor

janisz commented Feb 19, 2020

@vardhanapoorv test are not working :(

@jarifibrahim
Copy link
Contributor Author

Hey @janisz . I am aware of the test failure. There seems to be some configuration issue with the build. We'll fix it soon :)

Thank you for your PR.

jarifibrahim pushed a commit that referenced this issue Mar 4, 2020
@janisz
Remove coveralls from Travis Build(#1219)
3d95b94 
Fixes: #1196
jarifibrahim pushed a commit that referenced this issue Mar 12, 2020
@janisz
Remove coveralls from Travis Build(#1219)
5744fe3 
Fixes: #1196
(cherry picked from commit 3d95b94)
jarifibrahim pushed a commit that referenced this issue Mar 24, 2020
@janisz
Remove coveralls from Travis Build(#1219)
83fd5c3 
Fixes: #1196
(cherry picked from commit 3d95b94)
manishrjain pushed a commit to outcaste-io/outserv that referenced this issue Jul 6, 2022
@janisz
Remove coveralls from Travis Build(#1219)
46181dc 
Fixes: hypermodeinc/badger#1196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tools Issues related to maintenance tools and CLI. exp/beginner Something most people could solve. good first issue These are simple issues that can be picked up by new contributors kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove coveralls janisz/badger
3 participants
@janisz @jarifibrahim @vardhanapoorv