Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coveralls #1219

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Feb 13, 2020

Fixes: #1196


This change is Reviewable

@jarifibrahim
Copy link
Contributor

Hey @danielmai, Team City doesn't seem to run for this PR. This https://teamcity.dgraph.io/buildConfiguration/Badger_UnitTests?branch=pull%2F1219&buildTypeTab=overview tells me

The build was triggered in the branch pull/1219 which does not correspond to any branch monitored by the build VCS roots (the branch is either closed or excluded / not matched by any branch specification). Because of that default branch revisions were set to this build.

Do you know what's going on?

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks for the PR @janisz

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)

@jarifibrahim jarifibrahim merged commit 3d95b94 into hypermodeinc:master Mar 4, 2020
jarifibrahim pushed a commit that referenced this pull request Mar 12, 2020
Fixes: #1196
(cherry picked from commit 3d95b94)
jarifibrahim pushed a commit that referenced this pull request Mar 24, 2020
Fixes: #1196
(cherry picked from commit 3d95b94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove coveralls.io integration
3 participants