Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): add tool pick table benchmark #1699

Merged
merged 3 commits into from
May 10, 2021
Merged

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented May 10, 2021

Add benchmark tool for picktable benchmarking:

Usage:
  badger benchmark picktable [flags]

Flags:
      --cpuprofile string   Write CPU profile to file.
  -h, --help                help for picktable
      --read-only           If true, DB will be opened in read only mode. (default true)
      --sample-size int     Sample size of keys to be used for lookup. (default 1000000)

Global Flags:
      --dir string        Directory where the LSM tree files are located. (required)
      --vlog-dir string   Directory where the value log files are located, if different from --dir

This change is Reviewable

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jarifibrahim and @NamanJain8)


badger/cmd/pick_table_bench.go, line 44 at r1 (raw file):

var (
	po = struct {

Rename to opts, or pickOpts


badger/cmd/pick_table_bench.go, line 93 at r1 (raw file):

// printKeyStats prints out the key size histogram.
func printKeyStats(db *badger.DB) {

This seems like it should belong to badger info.

Copy link
Contributor Author

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @jarifibrahim and @manishrjain)


badger/cmd/pick_table_bench.go, line 44 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Rename to opts, or pickOpts

Done.


badger/cmd/pick_table_bench.go, line 93 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

This seems like it should belong to badger info.

Thanks. Its already there in --histogram flag of badger info.

@NamanJain8 NamanJain8 merged commit ca80206 into master May 10, 2021
@NamanJain8 NamanJain8 deleted the naman/pick-table-bench branch May 10, 2021 12:39
joshua-goldstein pushed a commit that referenced this pull request Feb 9, 2023
Add benchmark tool for picktable benchmarking.

(cherry picked from commit ca80206)
joshua-goldstein pushed a commit that referenced this pull request Feb 13, 2023
Add benchmark tool for picktable benchmarking.

(cherry picked from commit ca80206)
joshua-goldstein added a commit that referenced this pull request Feb 18, 2023
Add benchmark tool for picktable benchmarking.

(cherry picked from commit ca80206)
mangalaman93 pushed a commit that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants