-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bench): add tool pick table benchmark #1699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jarifibrahim and @NamanJain8)
badger/cmd/pick_table_bench.go, line 44 at r1 (raw file):
var ( po = struct {
Rename to opts, or pickOpts
badger/cmd/pick_table_bench.go, line 93 at r1 (raw file):
// printKeyStats prints out the key size histogram. func printKeyStats(db *badger.DB) {
This seems like it should belong to badger info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 2 unresolved discussions (waiting on @jarifibrahim and @manishrjain)
badger/cmd/pick_table_bench.go, line 44 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Rename to opts, or pickOpts
Done.
badger/cmd/pick_table_bench.go, line 93 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
This seems like it should belong to badger info.
Thanks. Its already there in --histogram
flag of badger info
.
Add benchmark tool for picktable benchmarking. (cherry picked from commit ca80206)
Add benchmark tool for picktable benchmarking. (cherry picked from commit ca80206)
Add benchmark tool for picktable benchmarking. (cherry picked from commit ca80206)
Add benchmark tool for picktable benchmarking:
This change is