fix(benchmarks): use uint32 in filename generation #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
added a commit
to orijtech/badger
that referenced
this pull request
Sep 10, 2021
odeke-em
added a commit
to orijtech/badger
that referenced
this pull request
Sep 10, 2021
To allow benchmarks to run.
ahsanbarkati
approved these changes
Sep 14, 2021
joshua-goldstein
pushed a commit
that referenced
this pull request
Feb 9, 2023
Note that the file ID can be 32 bit only, while the benchmarks were using 63-bit number for the same. (cherry picked from commit 292a4be)
joshua-goldstein
pushed a commit
that referenced
this pull request
Feb 13, 2023
Note that the file ID can be 32 bit only, while the benchmarks were using 63-bit number for the same. (cherry picked from commit 292a4be)
joshua-goldstein
added a commit
that referenced
this pull request
Feb 18, 2023
Note that the file ID can be 32 bit only, while the benchmarks were using 63-bit number for the same. (cherry picked from commit 292a4be)
mangalaman93
pushed a commit
that referenced
this pull request
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks fail at: https://github.com/dgraph-io/badger/blob/73314229872727d01f643cf42eb7c9702af59596/table/table.go#L663-L672. Note that the file ID can be 32 bit only, while the benchmarks were using 63-bit number for the same.
Addresses https://discuss.dgraph.io/t/benchmarks-fail-to-run-asserttrue-failing-and-many-files-not-found-errors/15467
This change is