-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tab title with the proxied document's title #154
Labels
Comments
3 tasks
robertknight
added a commit
that referenced
this issue
Apr 23, 2021
Send a `metadatachange` message containing the document title and URL to the parent frame when the DOM finishes loading so that Via 3 can reflect that metadata in the top frame. Part of #154
robertknight
added a commit
to hypothesis/via
that referenced
this issue
Apr 23, 2021
Listen for `metadatachange` messages sent via `window.postMessage` from the viahtml iframe and update the document title of top frame to reflect the current document in the proxied frame. Currently the title is the only proxied metadata but the mechanism could in future be extended to update the document URL, favicon etc. Part of hypothesis/viahtml#154
This was referenced Apr 23, 2021
robertknight
added a commit
that referenced
this issue
Apr 26, 2021
Send a `metadatachange` message containing the document title and URL to the parent frame when the DOM finishes loading so that Via 3 can reflect that metadata in the top frame. Part of #154
robertknight
added a commit
to hypothesis/via
that referenced
this issue
Apr 26, 2021
Listen for `metadatachange` messages sent via `window.postMessage` from the viahtml iframe and update the document title of top frame to reflect the current document in the proxied frame. Currently the title is the only proxied metadata but the mechanism could in future be extended to update the document URL, favicon etc. Part of hypothesis/viahtml#154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When Via HTML is proxying a third-party page in an iframe it needs to monitor for changes to the iframe's document title and echo these in the top-level tab title.
The tab title should be something like
Via - <third_party_document_title>
The text was updated successfully, but these errors were encountered: