Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the location bar URL when the iframe is navigated #156

Closed
seanh opened this issue Apr 19, 2021 · 1 comment · Fixed by hypothesis/via#478
Closed

Update the location bar URL when the iframe is navigated #156

seanh opened this issue Apr 19, 2021 · 1 comment · Fixed by hypothesis/via#478
Assignees
@robertknight
Labels
Frontend

Comments

@seanh
Copy link
Collaborator

seanh commented Apr 19, 2021

When Via HTML is proxying a legacy Via-style URL using an iframe, if the iframe's URL changes (e.g. due to a redirect) the top-level URL in the location bar should update (but without triggering a full page reload).
@seanh seanh added the Frontend label Apr 19, 2021
@seanh seanh mentioned this issue Apr 19, 2021
Merged
3 tasks
@robertknight
Copy link
Member

This can be implemented by extending the mechanism added to support #154. When the top bar receives a metadatachange message it can extract the current document URL from the proxied page and using the history API to update the Via 3 frame's URL.

This was referenced May 5, 2021
Closed
Merged
@robertknight robertknight self-assigned this May 5, 2021
robertknight added a commit to hypothesis/via that referenced this issue May 5, 2021
@robertknight
Reflect proxied document URL in top frame URL
bfb75cb 
Update the URL of the top frame to reflect the proxied URL currently
displayed in the content frame. This may be different than the initially
requested URL if it redirected.

For example https://stackoverflow.com/questions/<ID>/ redirects to
https://stackoverflow.com/questions/<ID>/<slug>. When visiting
https://via.hypothes.is/https://stackoverflow.com/<ID> the URL should be
updated to https://via.hypothes.is/https://stackoverflow.com/<ID>/<slug>
accordingly.

Depends on hypothesis/viahtml#170 and fixes
hypothesis/viahtml#156.
@robertknight robertknight mentioned this issue May 5, 2021
Merged
robertknight added a commit to hypothesis/via that referenced this issue May 6, 2021
@robertknight
Reflect proxied document URL in top frame URL
a9d9744 
Update the URL of the top frame to reflect the proxied URL currently
displayed in the content frame. This may be different than the initially
requested URL if it redirected.

For example https://stackoverflow.com/questions/<ID>/ redirects to
https://stackoverflow.com/questions/<ID>/<slug>. When visiting
https://via.hypothes.is/https://stackoverflow.com/<ID> the URL should be
updated to https://via.hypothes.is/https://stackoverflow.com/<ID>/<slug>
accordingly.

Depends on hypothesis/viahtml#170 and fixes
hypothesis/viahtml#156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertknight robertknight

Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reflect proxied document URL in top frame URL hypothesis/via
2 participants
@robertknight @seanh