Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ht07summer testing #6

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Ht07summer testing #6

wants to merge 34 commits into from

Conversation

RCMast3r
Copy link

Pull Request (PR) into Code-2024

Delete the below block when actually making your PR!

Before making a pull request, you must:
Follow HyTech's Github Software Guidelines to understand our development flow and pull request procedure.

Your PR should not cause any merge conflicts, so please merge the main branch into your branch before submitting. It is your responsibility to ensure that the merge does not break something before submitting. Here is a good resource for markdown formatting as you fill out this template. See this example. Feel free to ask any electrical lead if you have any questions!

Code Description

Describe the contents of the pull request. Describe what major files were changed. If you changed or added libraries, please give details on what those changes are.

Testing Description

Describe how you tested the contents of the pull request. Describe how each major change was tested. Describe how you ensured functionality regressions. Link to any gathered data from testing if possible.

Additional Information

Put any additional datasheets, information, and/or useful links here.

Checklist

  • Is this code linked to a new board or board rev?
    • Is there a PR for that board in circuits-2024? If so, please pause until that PR is merged.
  • If you made a change or addition or deletion to the CAN library, did you inform the Data Aq lead?
  • Did you test the code in real-world conditions before submitting?
    • Did you use CPU Speed = 720 MHz (overclock) and Optimize = Fastest when testing with Teensy 4.x?
    • Did you use CPU Speed = 144 MHz (overclock) and Optimize = Fastest with LTO when testing with Teensy 3.5?
    • Did you use CPU Speed = 120 MHz (overclock) and Optimize = Fastest with LTO when testing with Teensy 3.2?
    • Did you use Teensyduino 1.56 with Arduino 1.8.19 when testing with the latest libraries from main?
  • Did you pull main into your branch?
    • Did you check for merge conflicts?
    • Did you resolve any that occurred? If you are having trouble or are confused, contact a lead!
  • Did you fill out the above template?
  • Did you assign the right people for review (on the right)?

@RCMast3r
Copy link
Author

@shaynoorani this one is for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants