-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ht07summer testing #6
Open
RCMast3r
wants to merge
34
commits into
main
Choose a base branch
from
ht07summerTesting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
status not sure
@shaynoorani this one is for you |
Possible fix to current CAN message
Merged HT07_Summer_Testing Branch w/ Test_Coulomb_Counting Branch
…code-2024 into ht07summerTesting
current shunt should work. em and current shunt CAN also should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) into Code-2024
Delete the below block when actually making your PR!
Before making a pull request, you must:
Follow HyTech's Github Software Guidelines to understand our development flow and pull request procedure.
Your PR should not cause any merge conflicts, so please merge the
main
branch into your branch before submitting. It is your responsibility to ensure that the merge does not break something before submitting. Here is a good resource for markdown formatting as you fill out this template. See this example. Feel free to ask any electrical lead if you have any questions!Code Description
Describe the contents of the pull request. Describe what major files were changed. If you changed or added libraries, please give details on what those changes are.
Testing Description
Describe how you tested the contents of the pull request. Describe how each major change was tested. Describe how you ensured functionality regressions. Link to any gathered data from testing if possible.
Additional Information
Put any additional datasheets, information, and/or useful links here.
Checklist
circuits-2024
? If so, please pause until that PR is merged.main
?main
into your branch?