-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SimpleBlinds2 from config.schema.json and index.js #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longzheng
changed the title
Remove SimpleBlinds2 from config.schema.json
Remove SimpleBlinds2 from config.schema.json and index.js
Nov 27, 2022
05TEVE
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged into 3.1.0 as i will publish that as the next version. This will get merged into main upon testing completion. |
05TEVE
added a commit
that referenced
this pull request
Feb 5, 2024
Release 3.1.0 * Unify logs (#415) * Fixes for Local Key Updates by Tuya. (#413) * Adding back the original set multistate command as the new "setMultiState" function from PR #267 Breaks the Fan Code by splitting the command into two. For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues. This commit is is adding it back as "setMultiStateLegacy" so as to not revert the issue fixed in PR (#267). * Remove SimpleBlinds2 from config.schema.json and index.js (#390) --------- Co-authored-by: 05TEVE <> Co-authored-by: Valentin Dusollier <valentin.dusollier@icloud.com> Co-authored-by: Long Zheng <long.zheng@gmail.com>
ThisIsQasim
pushed a commit
to ThisIsQasim/homebridge-tuya
that referenced
this pull request
May 3, 2024
Release 3.1.0 * Unify logs (iRayanKhan#415) * Fixes for Local Key Updates by Tuya. (iRayanKhan#413) * Adding back the original set multistate command as the new "setMultiState" function from PR iRayanKhan#267 Breaks the Fan Code by splitting the command into two. For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues. This commit is is adding it back as "setMultiStateLegacy" so as to not revert the issue fixed in PR (iRayanKhan#267). * Remove SimpleBlinds2 from config.schema.json and index.js (iRayanKhan#390) --------- Co-authored-by: 05TEVE <> Co-authored-by: Valentin Dusollier <valentin.dusollier@icloud.com> Co-authored-by: Long Zheng <long.zheng@gmail.com>
ThisIsQasim
pushed a commit
to ThisIsQasim/homebridge-tuya
that referenced
this pull request
May 3, 2024
Release 3.1.0 * Unify logs (iRayanKhan#415) * Fixes for Local Key Updates by Tuya. (iRayanKhan#413) * Adding back the original set multistate command as the new "setMultiState" function from PR iRayanKhan#267 Breaks the Fan Code by splitting the command into two. For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues. This commit is is adding it back as "setMultiStateLegacy" so as to not revert the issue fixed in PR (iRayanKhan#267). * Remove SimpleBlinds2 from config.schema.json and index.js (iRayanKhan#390) --------- Co-authored-by: 05TEVE <> Co-authored-by: Valentin Dusollier <valentin.dusollier@icloud.com> Co-authored-by: Long Zheng <long.zheng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleBlinds2
no longer exists as an accessory type since this commit f85c4e3