Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify logs #415

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Unify logs #415

merged 3 commits into from
Jan 15, 2024

Conversation

valentindusollier
Copy link
Contributor

Most logs use console.log instead of the Logging object of Homebridge. I fixed it.

@05TEVE 05TEVE changed the base branch from main to 3.1.0 January 15, 2024 13:05
Copy link
Collaborator

@05TEVE 05TEVE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@05TEVE
Copy link
Collaborator

05TEVE commented Jan 15, 2024

Resolved merge conflicts due to my fan speed change.

@05TEVE 05TEVE merged commit c4f1b65 into iRayanKhan:3.1.0 Jan 15, 2024
@05TEVE
Copy link
Collaborator

05TEVE commented Jan 15, 2024

Changes merged into 3.1.0 branch for time being. After testing of beta is done, i will merge into main. 3.1.0-beta.5 has the changes included.

@dibsies
Copy link

dibsies commented Jan 16, 2024

Great work, @05TEVE ! It's so nice to see this plugin getting revived. Logs are looking a million times cleaner on latest beta. Is there any way to disable logging of adaptive lighting changes?

Example:

[15/01/2024, 16:50:59] [TuyaLan] setColorTemperature: 222
[15/01/2024, 16:50:59] [TuyaLan] setColorTemperature: 222
[15/01/2024, 16:50:59] [TuyaLan] setColorTemperature: 222
[15/01/2024, 16:50:59] [TuyaLan] setColorTemperature: 349
[15/01/2024, 16:50:59] [TuyaLan] setColorTemperature: 222
[15/01/2024, 16:50:59] [TuyaLan] setColorTemperature: 222
[15/01/2024, 16:50:59] [TuyaLan] setColorTemperature: 222
[15/01/2024, 16:51:00] [TuyaLan] setColorTemperature: 222

05TEVE pushed a commit that referenced this pull request Jan 17, 2024
@05TEVE
Copy link
Collaborator

05TEVE commented Jan 17, 2024

Hey , can you try with the latest beta 3.1.0-beta.13. This sets the logs as debug meaning they will only show if homebridge is running in debug mode.

@dibsies
Copy link

dibsies commented Jan 17, 2024

Installing beta 11 yesterday ended up shuffling my Tuya devices around in homekit. This broke my automations, scenes, and groups. I just got it all set up again and things are working great. I noticed that all of my devices have disappeared from the plugin settings page, though they still appear in the config file. Any thoughts into what might be going on?

@05TEVE
Copy link
Collaborator

05TEVE commented Jan 17, 2024

Hi @dibsies,There was a change that was implemented in 2.1.0 (unreleased) that changed the plugin name to Tuya instead of TuyaLan. Earlier versions of the beta contained that change. I have since figured out a way of keeping the config as TuyaLan to prevent users coming from 2.0.1 from needing to redo their configs. I got hit by the same issue and reconfiguring all the Tuya devices HomeKit is rather inconvenient.

Can you please config what version you have upgraded from and what the plugin is named in the config json? I have tested fresh installs and the upgrade from 2.0.1 and my configs are looking to be working as expected with 3.1.0beta-14.

@dibsies
Copy link

dibsies commented Jan 17, 2024

I want to say I was on beta 7 before upgrading to beta 11. Prior to that my path went something like 2.01 (latest public) --> beta 3 --> beta 7 --> beta 11. My config json says "platform": "TuyaLan".

@dibsies
Copy link

dibsies commented Jan 18, 2024

Updated to b13 today. So far, so good. No issues with update and logs are so quiet now. Thank you for your work!

@05TEVE
Copy link
Collaborator

05TEVE commented Jan 18, 2024

@dibsies.That's great to hear! Can you confirm whether the config issue is still there on version 13?

@dibsies
Copy link

dibsies commented Jan 19, 2024

@05TEVE config issue is gone. Everything is once again visible in the plugin settings 👍

05TEVE added a commit that referenced this pull request Feb 5, 2024
Release 3.1.0 

* Unify logs (#415)

* Fixes for Local Key Updates by Tuya. (#413)

* Adding back the original set multistate command as the new "setMultiState" function from PR #267 Breaks the Fan Code by splitting the command into two. For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues. This commit is is adding it back as "setMultiStateLegacy" so as to not revert the issue fixed in PR (#267).

* Remove SimpleBlinds2 from config.schema.json and index.js (#390)
---------

Co-authored-by: 05TEVE <>
Co-authored-by: Valentin Dusollier <valentin.dusollier@icloud.com>
Co-authored-by: Long Zheng <long.zheng@gmail.com>
ThisIsQasim pushed a commit to ThisIsQasim/homebridge-tuya that referenced this pull request May 3, 2024
Release 3.1.0 

* Unify logs (iRayanKhan#415)

* Fixes for Local Key Updates by Tuya. (iRayanKhan#413)

* Adding back the original set multistate command as the new "setMultiState" function from PR iRayanKhan#267 Breaks the Fan Code by splitting the command into two. For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues. This commit is is adding it back as "setMultiStateLegacy" so as to not revert the issue fixed in PR (iRayanKhan#267).

* Remove SimpleBlinds2 from config.schema.json and index.js (iRayanKhan#390)
---------

Co-authored-by: 05TEVE <>
Co-authored-by: Valentin Dusollier <valentin.dusollier@icloud.com>
Co-authored-by: Long Zheng <long.zheng@gmail.com>
ThisIsQasim pushed a commit to ThisIsQasim/homebridge-tuya that referenced this pull request May 3, 2024
Release 3.1.0 

* Unify logs (iRayanKhan#415)

* Fixes for Local Key Updates by Tuya. (iRayanKhan#413)

* Adding back the original set multistate command as the new "setMultiState" function from PR iRayanKhan#267 Breaks the Fan Code by splitting the command into two. For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues. This commit is is adding it back as "setMultiStateLegacy" so as to not revert the issue fixed in PR (iRayanKhan#267).

* Remove SimpleBlinds2 from config.schema.json and index.js (iRayanKhan#390)
---------

Co-authored-by: 05TEVE <>
Co-authored-by: Valentin Dusollier <valentin.dusollier@icloud.com>
Co-authored-by: Long Zheng <long.zheng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants